From: Zhihao Cheng <chengzhihao1@huawei.com>
To: SurajSonawane2415 <surajsonawane0215@gmail.com>,
<dwmw2@infradead.org>, <richard@nod.at>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: jffs2: Fix inconsistent indentation in jffs2_mark_node_obsolete
Date: Wed, 9 Oct 2024 09:07:09 +0800 [thread overview]
Message-ID: <442b62cc-a57d-04c4-0e25-07af7a0dad76@huawei.com> (raw)
In-Reply-To: <20241008182411.30387-1-surajsonawane0215@gmail.com>
在 2024/10/9 2:24, SurajSonawane2415 写道:
> From: Suraj Sonawane <surajsonawane0215@gmail.com>
>
> Fix the indentation to ensure consistent code style and improve
> readability, and to fix this warnings:
> fs/jffs2/nodemgmt.c:635 jffs2_mark_node_obsolete() warn: inconsistent
> indenting
> fs/jffs2/nodemgmt.c:646 jffs2_mark_node_obsolete() warn: inconsistent
> indenting
>
> Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
> ---
> fs/jffs2/nodemgmt.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/jffs2/nodemgmt.c b/fs/jffs2/nodemgmt.c
> index bbab2bdc7..cc51c85ef 100644
> --- a/fs/jffs2/nodemgmt.c
> +++ b/fs/jffs2/nodemgmt.c
> @@ -630,8 +630,8 @@ void jffs2_mark_node_obsolete(struct jffs2_sb_info *c, struct jffs2_raw_node_ref
> ref->flash_offset, jeb->used_size);
> BUG();
> })
> - jffs2_dbg(1, "Obsoleting previously unchecked node at 0x%08x of len %x\n",
> - ref_offset(ref), freed_len);
> + jffs2_dbg(1, "Obsoleting previously unchecked node at 0x%08x of len %x\n",
> + ref_offset(ref), freed_len);
> jeb->unchecked_size -= freed_len;
> c->unchecked_size -= freed_len;
> } else {
> @@ -641,8 +641,8 @@ void jffs2_mark_node_obsolete(struct jffs2_sb_info *c, struct jffs2_raw_node_ref
> ref->flash_offset, jeb->used_size);
> BUG();
> })
> - jffs2_dbg(1, "Obsoleting node at 0x%08x of len %#x: ",
> - ref_offset(ref), freed_len);
> + jffs2_dbg(1, "Obsoleting node at 0x%08x of len %#x: ",
> + ref_offset(ref), freed_len);
> jeb->used_size -= freed_len;
> c->used_size -= freed_len;
> }
>
prev parent reply other threads:[~2024-10-09 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 18:24 SurajSonawane2415
2024-10-09 1:07 ` Zhihao Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442b62cc-a57d-04c4-0e25-07af7a0dad76@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=surajsonawane0215@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®