mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jmerkey@wolfmountaingroup.com
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: jmerkey@wolfmountaingroup.com, linux-kernel@vger.kernel.org,
	"Ingo Molnar" <mingo@elte.hu>
Subject: Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr
Date: Thu, 14 Aug 2008 08:35:56 -0600 (MDT)	[thread overview]
Message-ID: <44303.166.70.238.45.1218724556.squirrel@webmail.wolfmountaingroup.com> (raw)
In-Reply-To: <84144f020808140139v691e6590idd79995168af4e9e@mail.gmail.com>

> On Thu, Aug 14, 2008 at 9:14 AM,  <jmerkey@wolfmountaingroup.com> wrote:
>> export the task_curr function to the module based kernel debugger to
>> enable
>> process back tracing and state display.
>>
>> Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com)
>>
>> --- a/kernel/sched.c    2008-08-13 14:22:32.000000000 -0600
>> +++ b/kernel/sched.c    2008-08-13 11:56:03.000000000 -0600
>> @@ -1736,6 +1736,9 @@
>>  {
>>        return cpu_curr(task_cpu(p)) == p;
>>  }
>> +#if defined(CONFIG_MDB_MODULE)
>> +EXPORT_SYMBOL_GPL(task_curr);
>> +#endif
>
> We usually don't export symbols conditionally, especially in core kernel
> code.
>

Well,then please suggest how a kernel debugger can be module based and still
be able to get this information some other way that's generic and minimal
impact.

Jeff



  reply	other threads:[~2008-08-14 14:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-14  6:14 jmerkey
2008-08-14  8:39 ` Pekka Enberg
2008-08-14 14:35   ` jmerkey [this message]
2008-08-14 15:05     ` Johannes Weiner
2008-08-14 14:49       ` jmerkey
2008-08-15 12:25     ` Ingo Molnar
2008-08-15 15:58       ` jmerkey
2008-08-15 16:39         ` Ingo Molnar
2008-08-15 16:26           ` jmerkey
2008-08-15 17:14             ` jmerkey
2008-08-15 16:13       ` jmerkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44303.166.70.238.45.1218724556.squirrel@webmail.wolfmountaingroup.com \
    --to=jmerkey@wolfmountaingroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®