Rene Herman wrote: > Yes. I don't see a significantly cleaner solution then than the > slightly hackish "using drvdata as a private success flag" that I > posted before. Example patch versus snd_adlib attached again. This > seems to work well. > > Takashi: do you agree? If the probe() method return is not going to > be propagated up, there are few other options. > > (Continuing the loop on IS_ERR(device) is then also a bit > questionable again as the IS_ERR then signifies an eror in the bowels > of the device model, but I feel it's still the correct thing to do) If you do agree, here's both patches generated against 2.6.17-rc1-mm1. First, the continue on IS_ERR one again. ad1848/ad1848.c | 14 ++++---------- cmi8330.c | 14 ++++---------- cs423x/cs4231.c | 14 ++++---------- cs423x/cs4236.c | 14 ++++---------- es1688/es1688.c | 14 ++++---------- es18xx.c | 14 ++++---------- gus/gusclassic.c | 14 ++++---------- gus/gusextreme.c | 14 ++++---------- gus/gusmax.c | 14 ++++---------- gus/interwave.c | 14 ++++---------- opl3sa2.c | 14 ++++---------- sb/sb16.c | 14 ++++---------- sb/sb8.c | 14 ++++---------- sgalaxy.c | 14 ++++---------- sscape.c | 14 ++++---------- wavefront/wavefront.c | 14 ++++---------- 16 files changed, 64 insertions(+), 160 deletions(-) Rene.