From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbbEZIMW (ORCPT ); Tue, 26 May 2015 04:12:22 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58655 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbbEZIMU (ORCPT ); Tue, 26 May 2015 04:12:20 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Masahiro Yamada , linux-gpio@vger.kernel.org, Linus Walleij , Michal Simek , linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?S=F6ren?= Brinkmann Subject: Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure Date: Tue, 26 May 2015 10:12:13 +0200 Message-ID: <4437293.G26yCXqFQH@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1432613909-13457-1-git-send-email-yamada.masahiro@socionext.com> References: <1432613909-13457-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/Sc/eIIf7M4exSaz4XhllArNpuj6glzljbfDUrvRaR/tmIxPYlc xJ1ghmHJSbi5c8F8bf0E+hKIHeMuthDhNsXHfnvVSYIGSVZ0FSzJKVbiTti0HiKoZtoYckI k6RMo9HLom3GfFz8w9ssYDE6agmHJstq6gLPqaMJGMKv2p38ws/vXxIEl9AXfWpsW/GZDXg O610p8rBOgKJyKdnZo3uA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote: > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > index 04748a4..0ff653c 100644 > --- a/drivers/pinctrl/pinctrl-zynq.c > +++ b/drivers/pinctrl/pinctrl-zynq.c > @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev) > > pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl); > if (!pctrl->pctrl) > - return -ENOMEM; > + return -EINVAL; > > platform_set_drvdata(pdev, pctrl); > > One choice seems as bad as the other to me ;-) Could we add a pinctrl_register_reason() variant that returns a meaningful error code as ERR_PTR? Arnd