From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302E936C5B2 for ; Fri, 3 Jul 2026 08:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783066088; cv=none; b=aKb9TRUkjhpOOxYLxE9MNG8Ic+wgaGbrdtmemCDRPd8UBCadfe6Dw5JeeMlEuegN06HqYFkwBaMJmMg4ao5i2VyEBRP/sqgALF0djoP3ZqgsSq/wxBjnZRhpZncv5RcnW6x/vLqFStWqH/PeXNLvTipMlbyeNb6/lfjYbKA4Llo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783066088; c=relaxed/simple; bh=SABxmrpSsVm8A2Mic2cd6WWMecfoTNnX7lTCRtSFO3g=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=lPmy2U0AHuQvSTTypRT0mqqaMw1k8lcuCuOq9VhVC/yOpCI+4hC//JG3Ld4DarHpVm0pUUxXI0KxP+LE5oSqgyVUjLNlLjHU4dhXbcgGsdf2ysdYzOqzEO76A54w9PdqjiDW8hVOGntyYIn4Pn2n00VinMQx/4mQnDgJqNmtjOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LZsngP/2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fwbVDhOM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LZsngP/2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fwbVDhOM" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6635rqCb3088171 for ; Fri, 3 Jul 2026 08:08:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V4V2s7NHyHN6PrzMIzpSsbSssKK5Q81QPBKAbT+SxC8=; b=LZsngP/28qsZ2Wj4 Xr7V3rB98b4xXBNvUz1F2mFkH4NWMlSrQCNJiSezO4Zl41Hyr+3+ydPZYn/pEnVr 3T+xYofnGJojzCnpp0a6QnqvUVV37uxhO7siL9np7kUHcuOY5rrp1yyphdMRZrFR jLfoStscZvA3iqgmAyICsI+H7a7Iz1TdFvd1epWJBW5awBItDQDFc5t+4UxC2Juz GuHo+0helestKCp3um+pq8ivmakd4OJmeN71l5Kr3GcfDmb3hCnAKoQiwrbSYik7 S8cGMKPzmHqwa8tD40OT4TrgA/e1NjTRo496A/U+1GM3LGvkmb2hLTHCozABIsVE /1HRCA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5s2540p5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 08:08:06 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3811ae55313so366252a91.3 for ; Fri, 03 Jul 2026 01:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783066085; x=1783670885; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=V4V2s7NHyHN6PrzMIzpSsbSssKK5Q81QPBKAbT+SxC8=; b=fwbVDhOM23im39T0uEnIxE77TbH62GqkFOaNk1KOPfBr5toMifmUNS60t4lIZ8iEPo ssvciXQGrkNNl/kSK/mNKtkIJfZMrWgXo/NNKNy7wdwHaz+Tl/4ZLFccPisVlbhF2epq Qash1QrN44AjFyOUOb+IsJrOpM0/5LDkDbvUqxjwbLr/j4GGnlIeeWQT2k31duLf80AU Vn+1Wcykq9ErzbTHfkUvvHGUpS7aW8BhnLUuTof/iutmBZxU8kx8TYqRk5VLZO8ro+hz akFRGTnvbxeu1f8mxkL8usgStUAejgb/LVh02ZgremCl7NDyNWfI+UOiA88Nq8f4ld7a Pn+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783066085; x=1783670885; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=V4V2s7NHyHN6PrzMIzpSsbSssKK5Q81QPBKAbT+SxC8=; b=qdtKEDf3Qb0yJ0YPuuzJe7ThMFjtYn8vWBSRZOcv2wvg+JmXJKP+igiNbvbnM7BhlJ tpSDKyY/dCbmIpuhaXvAiEZjT4AvnKwbauc7jmim7ncDNTkcIECTpQp5q5HHvJwZ51BU pJch9RgZzZ4ouKo2zxFWbe1DY1fWjqQqxYLbHEeySzP25+yDaRTke2WoKLFfUnAaMqQF RGSVd9S6Awjxcp7gNGrwFRC9cl252Qi+eJsE0pA8f883TM0rPPqDxFs2tCetthLIOKik HEgjhwZbe0QURi3d9+umXn+3UbPgVVb6e/fT8L3pXQLNFH0hiTJ+rr9RmI0vwnOkygyr aWgA== X-Forwarded-Encrypted: i=1; AHgh+RovqsrfFeHADmRFZ7GLVxgMJ69u/rKDCAzHPrZo/OLJGlq42gk+WxQCzohFm2OuU4MSraxMXccwgLJ2BHE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbf6gt/JUtxQzxbvUBiFZLEfXykQSKJQfQesXzf6c/cGBfiQ2s HNCnsfR38JuIzjxkFSCufzSN3em1VuJIbvRG2cGg3J4RyY/OKsYDKCfLvKquNqsCV77vx1IWARf aXCNLb5dJOFUaHMbZheRIrsyXv5yDJBybUgxFsl/MMARWF9cd7kNKaK1/DJHdm+4PAD8= X-Gm-Gg: AfdE7ckBCiNEc1oFhA4OsN9/vMxlGTKNMhRf8B+h9M9M4zpASpIFWe97oMRUnPF43fa rX3sHmaxob59fALocUVJ1W1i5WoxO4P9LD2XSbuoIof5h8Wm0oBbKkl4VTf7BCaVJ54k2TYlBHF FberyJrmHsqa6y+sxIpAwddJXzqrClLXuyForzBBUgKi6Chmqti4ourwpm130D7WYdXOs20dI36 INM5XvDnrxJvSfDogHVnhRFft5PTsUWTfkdeV7WNPJeVPN5Fm3zkYL8wm6AaayeIfbU2f7P/76m r/7fK/IEmZmDimYr6f9NEv2tCn5k4XsDB5YtOC5Z0SEKcUVKLe8URybt4S9kHzbxzC8x35DMDF7 dWr8o2pV3Vdi6e/pGOv0CekJTsiKjULUoJ1WWwDZHfjeVOMquWRyp4kLFBqlrvu9Nm5KYdtCQ+W 8= X-Received: by 2002:a17:90b:1c8c:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-3811f512193mr2505713a91.2.1783066085037; Fri, 03 Jul 2026 01:08:05 -0700 (PDT) X-Received: by 2002:a17:90b:1c8c:b0:381:1f51:1ff0 with SMTP id 98e67ed59e1d1-3811f512193mr2505681a91.2.1783066084488; Fri, 03 Jul 2026 01:08:04 -0700 (PDT) Received: from [10.133.33.27] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38127c1c68bsm599047a91.7.2026.07.03.01.07.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 01:08:04 -0700 (PDT) Message-ID: <44393910-8fa6-4580-a70f-796c844e4639@oss.qualcomm.com> Date: Fri, 3 Jul 2026 16:07:55 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] net: ethernet: qualcomm: Unconstify function arguments passed by value To: Krzysztof Kozlowski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260702094908.79859-3-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US From: Jie Luo In-Reply-To: <20260702094908.79859-3-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=U7uiy+ru c=1 sm=1 tr=0 ts=6a476de6 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=PaHDVFjmPNp70HpvHSgA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: Zzs96JM2jVCS1aMt1wMoczC0YaKLcGTu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDA3NiBTYWx0ZWRfX5Wux5UjjeZnD jHv3X/Fqoa9HH49KJXa7kFmpsGcW+p15J/fIBB3p4HMSyDuPVtGpeqICpw+c8vHJht/VLB47kAt zXRrF3YEgLwSME/nOcRQJ0HhZHrVgGVOhSNhk8GwM0XfJAruavbKd/o27tJ6SA2HxnuMHt383VI y8g3FaV1ZIv0Voeb9thFG7G0+bP/K4uaDYRwrv4rREFKOVuJWJZ8qoYdNUP/H6sQymG/Ddp2L5K sve4aIPcl5395sBJodccQOazzVPyDjvG9WNXmkmQBJd1uWiNIq2D+d5J44AgQOY7e2RgmwUQ1KJ aBnmlnBPHgrgqTFMuE5a3YkvPnr1Gjzt4XXgOmqbOxAU1SsXiuKMk6kWAkrvX2/mLsTidknS0Ua vqTOSRcqPU0xg56HANiPNNZZrPEL93oKU6vsth5rlhvTA6MzwzInOFYi92YzeCFiy8/WMUFzzQU +7GT7mR3wrZPAfsEZ+Q== X-Proofpoint-GUID: Zzs96JM2jVCS1aMt1wMoczC0YaKLcGTu X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDA3NiBTYWx0ZWRfXwvJOYND70vtf Wy793IsOpCWtB75BF+Mn+bJWQp+JqM8gqgQn7dIFuWCw9ATSotpkW2ZQ5igBog3QXf6Oeb6j00l 2ulVmWW/0oL6Xh5LGde6tjJcOPowBew= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030076 On 7/2/2026 5:49 PM, Krzysztof Kozlowski wrote: > There is no benefit in marking "const" a pass-by-value (not a pointer) > function argument, because it is passed as a copy on the stack. No code > readability improvements, no additional compiler-time safety for misuse. > Drop such redundant "const". Reviewed-by: Luo Jie