From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Changhuang Liang <changhuang.liang@starfivetech.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jack Zhu <jack.zhu@starfivetech.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>
Subject: Re: 回复: [v1] staging: media: starfive: Renamed capture_raw to capture_dump
Date: Thu, 21 Mar 2024 13:49:26 +0100 [thread overview]
Message-ID: <443e9909-7036-48a4-a1ea-c3908263282e@xs4all.nl> (raw)
In-Reply-To: <SHXPR01MB0671C5F9FD505906E460FA2FF232A@SHXPR01MB0671.CHNPR01.prod.partner.outlook.cn>
On 21/03/2024 1:17 pm, Changhuang Liang wrote:
> Hi, Hans
>
> Thanks for your comments.
>
>> On 01/03/2024 8:00 am, Changhuang Liang wrote:
>>> The pixel formats captured by the capture_raw video device depends on
>>> what pixel formats come from the source device. It is actually dump
>>> the source device data. So renamed it to capture_dump.
>>
>> I don't think 'dump' is a great name. I think what you really want to say is
>> 'unprocessed'. And usually that is indeed called 'raw capture'.
>>
>
> StarFive JH7110 SoC also supports the output of the raw format data from ISP port, see:
>
> https://lore.kernel.org/all/20240306093334.9321-1-changhuang.liang@starfivetech.com/
>
> So I think it is better to call the ISP output port "capture_raw".
If it is processed by the ISP, how can it be 'raw'? Or do you mean that this uses Bayer pixelformat?
The normal convention AFAIK is that the term 'raw capture' generally means that
the sensor bayer data is captured without being processed (or only minimal processing).
Looking at:
https://lore.kernel.org/all/20240306093334.9321-6-changhuang.liang@starfivetech.com/
I think you indeed mean that you can get the processed ISP data in bayer format
through a separate video device. So I would call that port 'capture_bayer' and keep the
'capture_raw' name for the port from the CSI receiver.
Regards,
Hans
>
> On the other hand, Old "capture_raw" video devices can also support YUV color space,
> mainly depending on the camera output format. There may be a confusion called it "capture_raw".
>
> Regards,
> Changhuang
>
>
next prev parent reply other threads:[~2024-03-21 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 7:00 Changhuang Liang
2024-03-21 9:57 ` Hans Verkuil
2024-03-21 12:17 ` 回复: " Changhuang Liang
2024-03-21 12:49 ` Hans Verkuil [this message]
2024-03-21 13:17 ` 回复: " Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443e9909-7036-48a4-a1ea-c3908263282e@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=changhuang.liang@starfivetech.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack.zhu@starfivetech.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®