From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbdBNLUa (ORCPT ); Tue, 14 Feb 2017 06:20:30 -0500 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:62453 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752157AbdBNLUO (ORCPT ); Tue, 14 Feb 2017 06:20:14 -0500 From: "Rafael J. Wysocki" To: Srinivas Pandruvada Cc: Doug Smythies , len.brown@intel.com, dsmythies@telus.net, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2] tools/power/x86: Debug utility for intel_pstate driver Date: Tue, 14 Feb 2017 12:15:18 +0100 Message-ID: <4440842.OSZWjPAjve@aspire.rjw.lan> User-Agent: KMail/4.14.10 (Linux/4.10.0-rc3+; KDE/4.14.9; x86_64; ; ) In-Reply-To: <1487045940.3025.5.camel@linux.intel.com> References: <1487027947-14306-1-git-send-email-dsmythies@telus.net> <1487045940.3025.5.camel@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, February 13, 2017 08:19:00 PM Srinivas Pandruvada wrote: > On Mon, 2017-02-13 at 15:19 -0800, Doug Smythies wrote: > > This utility can be used to debug and tune the performance of the > > intel_pstate driver. > > This utility can be used in two ways: > > - If there is Linux trace file with pstate_sample events enabled, > > then > > this utility can parse the trace file and generate performance plots. > > - If user has not specified a trace file as input via command line > > parameters, then this utility enables and collects trace data for a > > user > > specified interval and generates performance plots. > > > > Signed-off-by: Doug Smythies > > I am fine with this version. But since Rafael may have already prepared > for pull request, so it is up to him. I can replace your version with this one if that's OK. Thanks, Rafael