mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "Li, Xiaoyao" <xiaoyao.li@intel.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"kas@kernel.org" <kas@kernel.org>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] KVM: TDX: Fix the exit reason handling
Date: Wed, 12 Aug 2026 20:21:50 +0000	[thread overview]
Message-ID: <4447e3f5a6c6fa5c64774c8b1a28fd901833b8bd.camel@intel.com> (raw)
In-Reply-To: <1a7bff3b-731b-4990-8267-82d08669c8ee@intel.com>

On Wed, 2026-08-12 at 15:29 +0800, Xiaoyao Li wrote:
> Well, actually the added comment cannot be shared. For the 
> EXIT_REASON_EPT_MISCONFIG case, the reason to return a synthesized 
> invalid Exit Reason is to differentiate with the case of 
> TDVMCALL(ept_violation), where the exit reason is updated to EPT_MISCONFIG.

Ah, yea. You are right.

> 
> In fact, we don't need such trick for real EPT_MISCONFIG, because there 
> is handling for real EPT_MISCONFIG in tdx_handle_exit()
> 
> 	if (unlikely(vp_enter_ret == EXIT_REASON_EPT_MISCONFIG)) {
> 		KVM_BUG_ON(1, vcpu->kvm);
> 		return -EIO;
> 	}
> 
> before the handling of transformed EPT_MISCONFIG from 
> TDVMCALL(ept_violation)
> 
> 	switch (exit_reason.basic) {
> 	...
> 	case EXIT_REASON_EPT_MISCONFIG:
> 		return tdx_emulate_mmio(vcpu);
> 
> But it's not urgent to fix it and it's not mandatory to enable Bus Lock 
> VM exit on TDX. Let's leave it to the follow-up series.

Ok.

  reply	other threads:[~2026-08-12 20:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 11:21 [PATCH v2 0/3] KVM: TDX: Enable VM-DoS Prevention Features for TDX Xiaoyao Li
2026-08-10 11:21 ` [PATCH v2 1/3] KVM: TDX: Enable Notify VM exit Xiaoyao Li
2026-08-11  0:37   ` Edgecombe, Rick P
2026-08-10 11:21 ` [PATCH v2 2/3] KVM: TDX: Fix the exit reason handling Xiaoyao Li
2026-08-11  0:03   ` Sean Christopherson
2026-08-11  3:17     ` Xiaoyao Li
2026-08-11 17:36       ` Sean Christopherson
2026-08-11  0:38   ` Edgecombe, Rick P
2026-08-11  1:32     ` Xiaoyao Li
2026-08-11 15:20       ` Edgecombe, Rick P
2026-08-12  7:29         ` Xiaoyao Li
2026-08-12 20:21           ` Edgecombe, Rick P [this message]
2026-08-13  0:16       ` Sean Christopherson
2026-08-13  8:34         ` Xiaoyao Li
2026-08-13 18:19         ` Edgecombe, Rick P
2026-08-10 11:22 ` [PATCH v2 3/3] KVM: TDX: Enable Bus Lock VM exit Xiaoyao Li
2026-08-11  1:18   ` Edgecombe, Rick P
2026-08-11  1:44     ` Xiaoyao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4447e3f5a6c6fa5c64774c8b1a28fd901833b8bd.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®