From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095DC204C36 for ; Fri, 9 Jan 2026 15:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767973185; cv=none; b=Cy7wdExXl60eFJQEv3L0uh4hG6wM/B5qRSe4qypi0Bd7+Jfw5DVlu3JySpvc2TGO9fhnFDSUBP20FAehd3IgX6gLCMV4/Kp8hhTTUVniVwDNhp5jwiMokkyP05lHDHM3z4W2XvYKunNpUvZFaT0YKdhk6SpKMqK38kxKb4pXbYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767973185; c=relaxed/simple; bh=t+TLtvfo0Y4sPoq1UcBUjQp0L0OVZvCiAQsdXNm4U3Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lF6j9saJi6GIGa8/fFaXav+u5Ddv3hiuDhXZRDzC1I0lWJtrjtGZm2I6KUTBIq3TNrfNiFRpvGYgMNMAZ7s/7nzeh+z8RPcWfyE0KmT6b4qaEmjlbV/BGuyGvg+oHYo60wH0wu9it574tEyyESar9RiNCo6n1q34H6SlZ+5l7WU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=FzEzxiov; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="FzEzxiov" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id CB8A110D517; Fri, 9 Jan 2026 16:39:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1767973182; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=dYwKFBcUtK4Rx4f+T49zHTYVzFZ55JP4xbeOLffPN+4=; b=FzEzxiovriPgnH32SpLsVhUEYQREd+Jum4RYPIgWQZH1tmlTIgqY1kdcDQV/MoXKSonntn T65/D0cgQe5x/Pi/IzfcuXEz4D4PUyUEy/cTfEh/rDKzMPhUnlf+5120x0Ne0LOkZfwORX 9Sht8kxezzW/a3mov4Jpqh5Mbt84yH+hHR/K8c+CNN136Jy5efC1j2QJKYenNza4gSSuqN +xIYTTNkW0lDH/Ji7LdHahi1ZnB4ot+Kc9c5PMzdyKTFnlBJn8DwBAqY2pvR7LGz7Dk04v c9lUCox4I6j2EZ8GLLvNmvcDDKUqHn1d58mhd9nt+P3T7n0xpkvGqRB5NH+lPg== Message-ID: <444b4bc1-7724-4ea1-8e1e-8f5e7945eff2@nabladev.com> Date: Fri, 9 Jan 2026 16:39:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused To: Sean Nyekjaer Cc: linux-kernel@vger.kernel.org, Lee Jones , Pascal PAILLET-LME , Paul Cercueil , kernel@dh-electronics.com References: <20260109041301.1344783-1-marex@nabladev.com> <7ckcqck23wdwi2plotdl2rat4mb6ve4cl33jljkdro3h32h5pc@2k3fdxwa267p> Content-Language: en-US From: Marek Vasut In-Reply-To: <7ckcqck23wdwi2plotdl2rat4mb6ve4cl33jljkdro3h32h5pc@2k3fdxwa267p> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 1/9/26 3:54 PM, Sean Nyekjaer wrote: > On Fri, Jan 09, 2026 at 05:12:09AM +0100, Marek Vasut wrote: >> Attempt to shut down again, in case the first attempt failed. >> The STPMIC1 might get confused and the first regmap_update_bits() >> returns with -ETIMEDOUT / -110 . If that or similar transient >> failure occurs, try to shut down again. If the second attempt >> fails, there is some bigger problem, report it to user. > > I don't think I have ever seen my devices fail to shutdown. > Have you ever seen the second call fail? I have sporadically seen the first call fail with timeout, not the second one yet. If the second call fails, I think we have a real bad hardware problem. Maybe these issues are hidden on devices which use SCMI too, so they never get properly fixed in the direct hardware access kernel drivers anymore, sigh.