From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FE7C1D63D1 for ; Sun, 11 Jan 2026 21:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768168079; cv=none; b=cmfbdJ9Rrhh1PgKdrDCekGQmFONI4dBYEw/B5NWuxKWddtDYHWLA95Y3DXW3H4uUEh/URZoc04KekkqTufFHP+YlxIj/rKpESwDwqmXml5VhGnBCp+P47RQxj2Tueci7z+KQr9TYHkfIeTNWFPfvCrWAo+Bqdg1jcrGhhp7zUfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768168079; c=relaxed/simple; bh=Hcc6haJcvMChzDXHBkIBzN/ZEjuxdlsnJS6aBn83rMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rfXk6R9tKFKl5mQGxr/4Haas5spYqYpTdkXVCTr6esWEjzxGgaDfS3tVJX7ZNLyGVv+Vxa0sqC+YZ6ykM21243DfqUcAcj1Y05uczY7yJiDtaULwe67OjT8iRXe+5gMkregvQuQlwdwBSOzyAUlCFKZ0Jt9LmR9/vyw8U9nMt5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GfdPft9g; arc=none smtp.client-ip=209.85.222.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GfdPft9g" Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-93f5b804d4aso2304619241.3 for ; Sun, 11 Jan 2026 13:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768168075; x=1768772875; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O+2gWstM/HyxPNL7mRybuJKtVgZIGjOSwpFyBi2YJ1c=; b=GfdPft9gl3xQ0uXKBX5LlgHx/P1+W/QXQ8W9Bk5Ykc9kPyL4f91g4N7APVN2o6K9At yx7mpYovjV9USlOsBpHM5eM8xPfTJFXAa8F7TXopnyuAecCcDL/MvAuEy+xdXrybM/fu +aZuC/qm00wJqNTzus1SOUR5ImZkZpg5w9z3hyruTMMqi1kUSvxHYkId9ULqpRBVx717 f1A5mURwq39zhbNTQ1YtQzysqE1Rrv/07F6OTpuTxJHuJTnoVGewM6ya1oEsmXHQFZpA fnJJCtpc3cKYFrp+KJo6YI2TOsZ4LhrakADYmNuQsDf/L1g215JofvOLsY3qzCTa+2m9 Ls4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768168075; x=1768772875; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O+2gWstM/HyxPNL7mRybuJKtVgZIGjOSwpFyBi2YJ1c=; b=NgDRURoCEcah4AqXFkOCUvY3h21lL7qYoQunSixL5NaFp0mZ1ylSftE1ntBVS5at3M rT3O68IEB7X7rZclTo/anAtPZCMTsss4m2BEza1YTPtts/j3oyDjkDoBNaL37OOJRL7G 17cPtOTJt4myUXn3mMqTUUOwrNeAx9tbLUjakJhmFj7Nh7oUU3H3DQx4E3PK9EcjSRC5 R6eNbfOssNlLj1B4DiFYXOmHDgl3W4/Hesjt+WGQKIDSGHFQiSbkvjvdXmNEmFvq+VF4 PahkJ6O5uzht2MSKnRaLNpfPTz/LiiGbAqQTi/w2X1kUYV9ztzobSJVsQndlEHz3rXss N1qg== X-Forwarded-Encrypted: i=1; AJvYcCVxvQtmSk7OpW+kR//7ykr/M2j+JJVZFFDCWvdh2YRq5wvtB2ctvtbt86bO+hJhS/cM73eVWUGfFeBk1Zg=@vger.kernel.org X-Gm-Message-State: AOJu0YwxwKJUtmiFVMGmK1/j9yFlacIgIlgoRdNlZSjjiEcu7dBCdQDz x/q/WAtL3IUjbDH6CzmjaSx8NTzJN2Ulg8bjXzjs1lQs80IBjLCi34WN X-Gm-Gg: AY/fxX6fSU+xrg3xJcrB79o35lT/cFKqYwROvFZCQS/0iQDf/KH4Mp/7OYzSysU2hEM 3AhqBk8+qlrwG7raJ8od8ncgd8XALSWVM4fZi0Hs+rabYA4oC5VW/VkV83O9rZDYdZImP3Hv9K3 dHBc8fevYEgDYAazBqiyDMGkgc/bGDZ5sotvclP94s98+b0Nbx0g4duFea6nOgL9eQNKLsah1iC 9wqTCd1leUFxyUtv2dH1A7KSJclOwbdjtNbCKR+aM8iEV8kJlIQ9C7tzS0Q1E0/+cyEHU/4+nhA 8FwhakQBKc2kBwRG2vew376Zdwaqf0fAJQqAooIyYsUpsmtzF98Q97+9SeIpiyhVgnJcdVFJftu VDiToIrG4J1cEWaMeHdSE65J2gOhiE110lhhiSGksxCXNBMLsitWkw0Zz1BW6kd4Te3HaWzHNDK j8TmkpduLiK/scgrMav8sa7HuWTqrR6vtr8FqouDA1/S6IXzUfyoM0raCPl6njaZ9QYuPH9lbq X-Google-Smtp-Source: AGHT+IEEYehPkZiKnQl/5kGTgWOJPrvUtSI8lKQuH2RFJUTTapZeRbZUz+fUsZYLVMBFyZRnXDSqOA== X-Received: by 2002:a05:6102:5e98:b0:5ee:a03c:8774 with SMTP id ada2fe7eead31-5eea03c97e8mr5339901137.28.1768168074993; Sun, 11 Jan 2026 13:47:54 -0800 (PST) Received: from ?IPV6:2804:d57:4e32:d200:d9b8:e236:f824:3578? ([2804:d57:4e32:d200:d9b8:e236:f824:3578]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ed082abc75sm14481849137.1.2026.01.11.13.47.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Jan 2026 13:47:53 -0800 (PST) Message-ID: <444e63b3-8971-464d-ad22-c52eb1295b53@gmail.com> Date: Sun, 11 Jan 2026 18:47:47 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8] rust: add new macro for common bitflag operations To: Miguel Ojeda Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , daniel.almeida@collabora.com, rust-for-linux@vger.kernel.org, felipe_life@live.com, linux-kernel@vger.kernel.org, Lyude Paul References: <20260111-feat-add-bitmask-macro-v8-1-3bc0a558ede0@gmail.com> Content-Language: en-US From: Filipe Xavier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/11/26 5:06 PM, Miguel Ojeda wrote: > On Sun, Jan 11, 2026 at 2:33 PM Filipe Xavier wrote: >> +// SPDX-License-Identifier: GPL-2.0 >> + >> +//! Common helper for declaring bitflag and bitmask types. >> +/// >> +/// This macro takes as input: > So I didn't mean to convert the first line to `//!`, but to add > documentation to the module between the SPDX line and the > documentation for the item. Oh, sorry, I misunderstood. I thought it might be redundant; I'll adjust it in the next version. > Please see how other files do it, e.g. `rust/kernel/slice.rs` and > `rust/kernel/irq.rs` are similar cases (no `use` blocks between `//!` > and the first item). > > But please wait a few days in case there is any other feedback -- > hopefully we are getting finally there. > > (By the way, in general, it is good to reply to the feedback messages > you get, to confirm or not whether you applied a particular > suggestion). > > Thanks for updating the docs and being persistent! I am the one who is grateful for the feedback and patience. Xavier