From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757087Ab3A2OpO (ORCPT ); Tue, 29 Jan 2013 09:45:14 -0500 Received: from forward20.mail.yandex.net ([95.108.253.145]:43647 "EHLO forward20.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756595Ab3A2OpL (ORCPT ); Tue, 29 Jan 2013 09:45:11 -0500 From: Kirill Tkhai To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , linux-rt-users Subject: Re:[PATCH]sched/rt: Do not try to push tasks if pinned task switches to RT MIME-Version: 1.0 Message-Id: <4451359470707@web16g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 29 Jan 2013 18:45:07 +0400 Content-Transfer-Encoding: 7bit Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, 2013-01-29 at 00:23 +0400, Kirill Tkhai wrote: > >> Just switched pinned task is not able to be pushed. If the rq had had >> several RT tasks before they have already been considered as candidates >> to be pushed (or pulled). > > Thanks, but I have one minor nit. > >> Signed-off-by: Kirill V Tkhai >> CC: Steven Rostedt >> CC: Ingo Molnar >> CC: Peter Zijlstra >> CC: linux-rt-users >> --- >> kernel/sched/rt.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c >> index 4e8f0f4..5f7d92b 100644 >> --- a/kernel/sched/rt.c >> +++ b/kernel/sched/rt.c >> @@ -1925,9 +1925,9 @@ static void switched_to_rt(struct rq *rq, struct task_struct *p) >> */ >> if (p->on_rq && rq->curr != p) { >> #ifdef CONFIG_SMP >> - if (rq->rt.overloaded && push_rt_task(rq) && >> + if (rq->rt.overloaded && p->nr_cpus_allowed > 1 && > > I would swap the order here. That is, check p->nr_cpus_allowed before > rq->rt.overloaded. The order doesn't really matter, and even though > rq->rt.overloaded is probably more likely to be 0, it is used by other > CPUs. And as a micro-optimization, I rather read something that is used > by only one CPU than to read something that may be modified by many > CPUs. > > -- Steve > I corrected. Thanks. [PATCH]sched/rt: Do not try to push tasks if pinned task switches to RT Just switched pinned task is not able to be pushed. If the rq had had several RT tasks before they have already been considered as candidates to be pushed (or pulled). Signed-off-by: Kirill V Tkhai CC: Steven Rostedt CC: Ingo Molnar CC: Peter Zijlstra CC: linux-rt-users --- kernel/sched/rt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 4e8f0f4..5aab032 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1925,9 +1925,9 @@ static void switched_to_rt(struct rq *rq, struct task_struct *p) */ if (p->on_rq && rq->curr != p) { #ifdef CONFIG_SMP - if (rq->rt.overloaded && push_rt_task(rq) && + if (p->nr_cpus_allowed > 1 && rq->rt.overloaded && /* Don't resched if we changed runqueues */ - rq != task_rq(p)) + push_rt_task(rq) && rq != task_rq(p)) check_resched = 0; #endif /* CONFIG_SMP */ if (check_resched && p->prio < rq->curr->prio)