From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92E1A54723 for ; Thu, 19 Mar 2026 03:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773889237; cv=none; b=iNfbrJNXM6Z6GvF8f+jIHzVgGuv9DjFqNgSew5YMH2ert2YVoymMIiETDZIAvOV6oeSY2NmjoxcahDqT8FwB9fujZJ7xIUSXgUuBga7o2PEJnB+TlBN39BxDK/hmaTxcaTTYunDKKqTJMnS+Wx8EOmyNVNv+KaVRi1qRC5Ubxio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773889237; c=relaxed/simple; bh=VYeTahab9dWHytauFsvLJ933SiY9clgiY8Jl+9WZr4A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j6uCWJFSpq/U6pa2S8tpDSYHMINa8V5wXtx0nh/6m6SA8jFWGK1OnA6DrpbSf3Alp2aegpTWKnNQVxDm4EWZNSA/e+dRkEKVwEfTt8zHgHpZMLuWJKqNnFH/e6uStdlCkP/ez/57w9uGLKE5ukcrYB+QgVX5+cJcZKIEqXDN4qE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nZ0v0NAV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c7ORanJd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nZ0v0NAV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c7ORanJd" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IMl1WS3769647 for ; Thu, 19 Mar 2026 03:00:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SJtrE0QaoN7ncD+Y1nbvcSE0oQoNr4XLNfo23aiMjk0=; b=nZ0v0NAVyDwmcsm9 C9+XbRCQ90c4OsAoJitgplAMg3pTQuyQxeu4Hnq9Ny6gF1bxSPGF5Qbqq9Cx1brk VqFTeOp5lXxE83zmVUeAbhvpDncD9IpLjZrA6PNVaxz3EkxfgOYlYDtMMzv0mND7 /9OTS/3AKf8fSoce2TQeFUd1dff2e8gZDO9T4B4kIbENfCpOOml13IjEBwk2PdKG I1GHKleKwdb2z1guLm2o3OL0X39JOj7i2q0EyxgkjkjkbkwIKkQi3PqUhI4GGqaq 4RGT+9qx5lAjzgL87FB2uuOQNQFekfcajsinD4MXdj9rP9EbKzfcqAwHWWzxC6Vj MyfcYw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cyqcduynf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 03:00:35 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b05d170cadso9160335ad.0 for ; Wed, 18 Mar 2026 20:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773889234; x=1774494034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SJtrE0QaoN7ncD+Y1nbvcSE0oQoNr4XLNfo23aiMjk0=; b=c7ORanJdPbNE9CMuoj856X+vipSeBxdaRqd5BAqiAjJPnhByCQsjjvUGj3mESBUi+Z XAg2CmaYQCuvewKcBTN1SfgjvWttLW0Kur4UHSBvYy7WHrP0oZdYY6yXASMFhUPFJV/2 XQj5MJ5fou2519M7o+WnNaEiC0g0nyhTHC0YY5IboxK2jr6loHBm3eLRMiGennFNSCVU GFU8lqYlsvva+4hUjpsh8gEcQZ+rS8CT8jnF377NdCt+gbBe97020hvol01CAanQ9tkB vMUXyB1o10Q1GimLPjut2WZB5OfpFc5jToR/GD0O4PuaK2W2HZX9hiszEzDh4VnSa0X2 XRbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773889234; x=1774494034; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SJtrE0QaoN7ncD+Y1nbvcSE0oQoNr4XLNfo23aiMjk0=; b=DsNBE7WilUdypyd/v6+pu6K9T8VhDk4lx8WK4MoKmdq7mVli56GxD2o/R+9bFfmCO+ tRhzolkENJEvMpjjgqDlNydNbwcCDjNXMONZWdIGkAnTiHNTdKbm16VTqc8TyT9VWbxM k9/yPe9Pz8MLeUllF8dN8MdgXdN4nBstzLId0Wao1hWqbDNKVkIJQaaH1/Etni8hFqJi 2EvFa19/F59vO6/NA3D478aiYYRJaJjtNv79fpM5wCX7Rc6BCTNKzR9ptb2DEqMuDnUY lwCtKOq4SPX4SoXfEmEgXI+YcvKNsSDAat0w6RFLidBIYbmQCrvaHhfO2ejW8oeRmqZ/ H5xg== X-Forwarded-Encrypted: i=1; AJvYcCUjfF3rzXMw2lR79gA6R4SOOOJhlmqEWm1q2mlhVKFRyiepw5z91kpKVHwdCddsjHscGcJuFztyDdFiCsk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr+tZvG9nGU24F65U8qNoqbRSJL2n7Lo2+xLNOWxxNtggd11Su U//MSwRXKomi/8w+kNv5d5JYZ3u1wx7fFJdIsBTH3cCNnkinQ4f+G1YybxJNQ7SaEgT4gQgB0wM jR0iBgwfJ43hDy6ZAZddvRS3xjgzauD0Umhzs3dacYMXxeDFPXCWAWtidJRp+MRMHCdU= X-Gm-Gg: ATEYQzyQAtujAyXrK9DieoglQfqS0S3dPZdH96aUJugQkxjj+lquLE1IietaKkEhsa6 xEGu+3q748mCmVns1xN22EVDo9R1LpMlcqg/1nprITa4PaWWsGjBnuon7FzuKKxT0VpCDAa25Tt eM00dCE9TZjhElnwBmvFnEhR0IsMbnLA4h+jqMDJQnCrg96XzEFFY4eRRvn7MNWaPfcgfc9F9g4 SkA5PVJhcjnIMWZyW+8R1y2vikgPfY7c/CwwEwOUEzmJse2b8zPyo0OK+GJCtiAbJ6H+/Vbj9rU PJDEOpYoIVoIqzijp8QuwK7ZwDZp46JEV3LBXVAczfRtLhD45/KNbNJAUW9TpNucpF6ERV049pv w11k6lZ7pjUkYjjSmO3D0UYfiDw3VGKFxbkQwpBn6UQbLsOCXw5DpPjaVEYeWq7v48eIdwod3uR f/mhk2pGudLQYteuRvFyE= X-Received: by 2002:a17:903:37c6:b0:2ae:7f28:124b with SMTP id d9443c01a7336-2b06e3554d7mr64196045ad.22.1773889229682; Wed, 18 Mar 2026 20:00:29 -0700 (PDT) X-Received: by 2002:a17:903:37c6:b0:2ae:7f28:124b with SMTP id d9443c01a7336-2b06e3554d7mr64195545ad.22.1773889229010; Wed, 18 Mar 2026 20:00:29 -0700 (PDT) Received: from [10.133.33.235] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e627132sm43286915ad.74.2026.03.18.20.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 20:00:27 -0700 (PDT) Message-ID: <44549364-7187-4b1a-b1fe-5bf6e309ec16@oss.qualcomm.com> Date: Thu, 19 Mar 2026 11:00:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: fix MAC address copy on big endian To: Alexander Wilhelm , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260317-fix-mac-addr-copy-on-big-endian-v1-1-b7b6c49cb07f@westermo.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260317-fix-mac-addr-copy-on-big-endian-v1-1-b7b6c49cb07f@westermo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDAyMSBTYWx0ZWRfX5PcdFROoaQmH dOGkJ2vDZitgOeckG7MHO6Mc0E1ECfKGVQuZk/J2fcbDLtc+wu5U2YInCBOvJE9t+MYk6BUI9ic 59IJGRDybgK/7pRnjqZKsUv7+to88b2mwXhtG1lxd/EonPccFU3M4uCuDO0R1lgLLtdq2vqTUQ/ pOxS/fTIo+0tFZtn4hT2t9TXn6nuXtwFTWTAspb69XDXJOyHfB+hLUHSIweqSVVPS5h2+CG2pYN BFQpvig5Cic9594sg1xmv9ariHAjj+HsHJYExf8o4QHNmc4a1OsTRYrh3AdHaj9vIVnSjBHE7eL hE7KhjstNl4yj/ITRgQDgcz892JiXgey1haGu3pkxzvMYrENta6zDAIj3Xbd5gFWAAAfRpG6XSI x3K7bK+jFrJ+0P2QU7Tu5piFopSEBaL6Lx6sYQxuMM7utrqdISDSYpqExcCvhV/G6PFdbpFrw05 jE/cgvQ+hsk0u3LZI2Q== X-Proofpoint-ORIG-GUID: iyKNjQDH1a372hi9a5k5M0FZgaPjGpyP X-Authority-Analysis: v=2.4 cv=H87WAuYi c=1 sm=1 tr=0 ts=69bb66d3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=N9GNhs4bAAAA:8 a=ywX3x0iTvHv4trEmZJsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=PZhj9NlD-CKO8hVp7yCs:22 X-Proofpoint-GUID: iyKNjQDH1a372hi9a5k5M0FZgaPjGpyP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_02,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190021 On 3/17/2026 7:22 PM, Alexander Wilhelm wrote: > The ath12k_dp_get_mac_addr function performs a simple memcpy from a > CPU-native data types into an u8 array. On a big-endian architecture, this > later results in a null‑pointer dereference. Convert the data to curious how could this happen? how matter the endian, it is just six bytes which are not a pointer hence can not be dereferenced, no? > little‑endian first, then copy it into the target array. > > Signed-off-by: Alexander Wilhelm > --- > drivers/net/wireless/ath/ath12k/dp.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h > index f8cfc7bb29dd..50957915dbf4 100644 > --- a/drivers/net/wireless/ath/ath12k/dp.h > +++ b/drivers/net/wireless/ath/ath12k/dp.h > @@ -647,8 +647,11 @@ int ath12k_dp_arch_rx_tid_delete_handler(struct ath12k_dp *dp, > > static inline void ath12k_dp_get_mac_addr(u32 addr_l32, u16 addr_h16, u8 *addr) > { > - memcpy(addr, &addr_l32, 4); > - memcpy(addr + 4, &addr_h16, ETH_ALEN - 4); > + __le32 le_addr_l32 = cpu_to_le32(addr_l32); > + __le16 le_addr_h16 = cpu_to_le16(addr_h16); > + > + memcpy(addr, &le_addr_l32, 4); > + memcpy(addr + 4, &le_addr_h16, ETH_ALEN - 4); > } > > static inline struct ath12k_dp * > > --- > base-commit: 702847e8cfd51856836a282db2073defd7cfd80c > change-id: 20260317-fix-mac-addr-copy-on-big-endian-f1a4fea40184 > > Best regards,