From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751354AbdJWJLM (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 05:11:12 -0400
Received: from mout.web.de ([212.227.15.14]:56914 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750811AbdJWJLL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 05:11:11 -0400
Subject: Re: ARM: mvebu: Use common error handling code in
 mvebu_armada_pm_init()
To: Dan Carpenter <dan.carpenter@oracle.com>,
        linux-arm-kernel@lists.infradead.org
Cc: Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Russell King <linux@armlinux.org.uk>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <1c378b21-f10a-3a3a-fcee-8f0c0214a8fe@users.sourceforge.net>
 <20171023085718.lga7auriq7paw2hv@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <44577789-a2e8-4c1a-9abc-a34a17ae2e22@users.sourceforge.net>
Date: Mon, 23 Oct 2017 11:10:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023085718.lga7auriq7paw2hv@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:aKC180pHltAaRMD6we7l6vVLd8VZ7XcmAJlCtqGub3rrjuvmqt2
 0hArmmzLQ5lDB8ELjSuOMtAP8V9CPnre2Ukm8w9DOT7YTNlJ0ZPha6/d9eq2eIx9SbcHd9v
 EW4o3KAHHQAhFyUezc1HC/pxyE+8wy1m8LOkSM+Ypa/7SSi/M6hn/xfCttjb0AaLkiIc6Vf
 VzIBOgb6IcIHWssldjJZg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:kPtM4NMDdCc=:3N+HNRQUxJAju5McYdotKS
 MWbCK2ZFoOk6UfxGeKbVR/s97kYIcAsJHn2y2cehF2bBgQTAnLGV8tiz20yeqVXzKDRWULdPT
 qW2EB2QpO/T17A8wNjNSvcaroNboyJlyJTYyCWXyo2wSqDKkS5EVfJLGGZ0yeJLvO1sgUh9GW
 QGTignTnQ+aTHZxwpxMrUp0EC3JaePPouzY5Xy6UZjKKBNe6T/gPulG35kIAOv9pxEiWaiqgI
 5AaMa/UE4rjT6r8j/HiBRIX9+kPrT11pFUltHv24+gvxC1kK2btpM5AYLyq7KGBEouGQDhkwY
 c0vtRr+S0CwovObp/luPmWJvnvcbt5wnpd70PkaeSYNu4uVlTKTyTPLXvI8DMpjM7Aj8oEGmB
 OiE6TGLu6KuPKzt4ucTyrP6CULQflVqfEKZcleeIiFnquhxCczC8ht/s7VGYrX9QDoaA4GRDr
 5WyjyPS9sgOM7AkHlzRpxNX42KRQwnWrO7sLA3eaPPHV3By5bnH1DLcXMCZVstk6y5Px2Di14
 LbB0vtu/nBhRXhOnKv+xXaqF+U7+wh/U9dNblQt+GRDndJz95ZnuSDCYb6T3jXjSzwa3s2r5f
 tXQJ0l7z82twMTAtIh6VwF33qNjdVf29vnxIHlFSLveP8E/6Oi9iebi25RjO65lk2sX4D1TWV
 S1Ass8VYUOmfFnEVqREgeE8RJQYTsbG5eFT1tqOA7rXymBw3doLRfNfzauYtTQcueeZsyaQqx
 3I67sjhI5uW17+zbXagCOGR0eeexAaTeR9pTvjddz+D6mQpai9EwKkhZJMLxLgN9WwckJp/kl
 1hPObmXzR61vEnZG3MZ9j12tzGQaDRLX1gPepS1m9EQHSR39kc=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The error handling in mvebu_armada_pm_init() is incomplete

How would you like to extend it?


> and this patch just smudges it around without fixing anything.

How does this kind of feedback fit to information from the section
“7) Centralized exiting of functions” in the document “coding-style.rst”?

Regards,
Markus