From: "Jan Beulich" <jbeulich@novell.com>
To: "Suresh B Siddha" <suresh.b.siddha@intel.com>
Cc: <akpm@osdl.org>, <tigran@veritas.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix x86 microcode driver handling of multiple matching revisions
Date: Fri, 05 May 2006 08:50:57 +0200 [thread overview]
Message-ID: <445B11F1.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20060504100940.A2571@unix-os.sc.intel.com>
>> + for_each_online_cpu(cpu_num) {
>> + if (ucode_cpu_info[cpu_num].mc == uci->mc) {
>> + uci->mc = NULL;
>> + break;
>> + }
>
>Isn't there a memory leak here? Shouldn't this be
> for_each_online_cpu(cpu) {
> if (cpu == cpu_num)
> continue;
> if (ucode_cpu_info[cpu].mc == uci->mc) {
> uci->mc = NULL;
> break;
> }
> }
Indeed, I'll send an updated patch later.
Jan
next prev parent reply other threads:[~2006-05-05 6:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 14:17 Jan Beulich
2006-05-04 7:28 ` Tigran Aivazian
2006-05-04 8:00 ` Jan Beulich
2006-05-05 7:55 ` Tigran Aivazian
2006-05-04 17:09 ` Siddha, Suresh B
2006-05-05 6:50 ` Jan Beulich [this message]
2006-05-05 11:26 ` [PATCH, updated] " Jan Beulich
2006-05-06 20:26 ` Tigran Aivazian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445B11F1.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome