From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584B2C4332F for ; Mon, 11 Apr 2022 14:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347455AbiDKOtW (ORCPT ); Mon, 11 Apr 2022 10:49:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229782AbiDKOtU (ORCPT ); Mon, 11 Apr 2022 10:49:20 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A770613CCD; Mon, 11 Apr 2022 07:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=0PQqok4VtRI+EwdhTAimsSjz59ctIfWRywOAu+VFE1Y=; t=1649688425; x=1650898025; b=p2I19GvzgotvmG6EWeIK5/pglK/kmHE0QvxQZBDPA6voskx nYmiFgGav/m/ERvIE2oMboDlzjFWzyjLPuTYqSL9vObAsb9xB8hK2am8b8+ZFh/iDxT49h8ZohLdH oJwy+AJchpci6CwEVS8F8qWC8Nvo2JcI1qocKhUWX3S6PzHqbKetdaFCdwXFRD3eCF3A9fHkthT46 zOyCc48EQbaT+s1lSZGs84Xiyn9uJ3QfB3MFw3xdqYb9GobKdCFdP2aQyh5VHqSGFmZQ+Rht6CBdr 2YgCZo6vKZ7MEMhHfgh8UNIFDOWxbbcsEDPM386Ksi+Musm2tEGJUCP/5HaDil7w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1ndvJY-008KQx-UY; Mon, 11 Apr 2022 16:46:49 +0200 Message-ID: <446ea9872d46fe0ad594cfa6d3df224cfcb5223f.camel@sipsolutions.net> Subject: Re: [Linux 5.18-rc1] WARNING: possible circular locking dependency detected at (rtw_ops_config, ieee80211_mgd_probe_ap) From: Johannes Berg To: Ammar Faizi , Linux Kernel Mailing List Cc: "David S. Miller" , GNU/Weeb Mailing List , Jakub Kicinski , Kalle Valo , Linux Wireless Mailing List , netdev Mailing List , Paolo Abeni , Yan-Hsuan Chuang Date: Mon, 11 Apr 2022 16:46:47 +0200 In-Reply-To: <875af62c-363e-3fc3-9c38-dcf8b3071c99@gnuweeb.org> References: <2565e500-0e2f-c688-19e0-d241e4e7e031@gnuweeb.org> <875af62c-363e-3fc3-9c38-dcf8b3071c99@gnuweeb.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-04-07 at 08:26 +0700, Ammar Faizi wrote: > > [21860.955836] Possible unsafe locking scenario: > > [21860.955837] CPU0 CPU1 > [21860.955837] ---- ---- > [21860.955838] lock(&local->iflist_mtx); > [21860.955839] lock(&rtwdev->mutex); > [21860.955840] lock(&local->iflist_mtx); > [21860.955841] lock(&rtwdev->mutex); > [21860.955842] > *** DEADLOCK *** > The driver needs to fix this, cannot call ieee80211_iterate_interfaces() inside a section locked this way. I _think_ this deadlock used to be documented by it looks like that documentation got moved around or something. johannes