From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EFD27C178; Mon, 20 Oct 2025 18:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760986391; cv=none; b=uWBkj2TiyTuKOTXvdHFcEYTdVROfkhmUhxsvc+3LZstuN3fwaS7YVKu0OGOxN7DjtnYI4myBvXwxGlpFGmNxrVOkFdUKT1zo7hyUF91QxaRtCs/4X/fP0eKc6j9ud5ScQdn9Ac9i/vD5adQwRB9CezYE704+Bc98H7MhzszQmAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760986391; c=relaxed/simple; bh=SUABQBDAygzCg8T3H5z6ugGs+gGOkCEsxHL8FvpK/Kw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CzbKZ38CDBOdgkgqGiHefV7O4/pipmUjZU5osWagvOjiXGDgg2PANzVKkeaBp6nupozWf7QBeE3BrHx9dGJbWnqvEdKS+eNXd4uHHhzcewL9f6tJ65IK4FmuBpyL+DGFDbawJMBU5EP2bdY4kwM76N3ZTZlZxDL/V/ntklIKA28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=e8ozeaC+; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="e8ozeaC+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=nY4Sp4VSEr+tgyiDJpJJY1QovLdkM2vWDgPSyGfuHQQ=; b=e8ozeaC+vmaCILVfrZRYRuCAsr 4EfJkbu6kTbeUOQCpButNPaGXKz6vDxyXZGRQFq7oQGXNOHmDobIl8KUNR4tLltzYqYbZsJUeXynk rT8YZKaaldwdysDnSwmKQ60XjoIR0rVgEnbeLI7u6js90ZXkTqpHdhmt8/97Rs5gCuAM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vAuzs-00BY6J-KL; Mon, 20 Oct 2025 20:52:44 +0200 Date: Mon, 20 Oct 2025 20:52:44 +0200 From: Andrew Lunn To: Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Maxime Coquelin , Alexandre Torgue , Heiner Kallweit , Russell King , "Russell King (Oracle)" , Han Gao , Icenowy Zheng , Vivian Wang , Yao Zi , netdev@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v2 3/3] net: stmmac: dwmac-sophgo: Add phy interface filter Message-ID: <4470b79a-af47-452e-b187-5646884d0cb9@lunn.ch> References: <20251020095500.1330057-1-inochiama@gmail.com> <20251020095500.1330057-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251020095500.1330057-4-inochiama@gmail.com> > + data = device_get_match_data(&pdev->dev); > + if (data && data->has_internal_rx_delay) > + plat_dat->phy_interface = phy_fix_phy_mode_for_mac_delays(plat_dat->phy_interface, > + false, true); You should check the return value and if it is _NA, return -EIVAL. Andrew --- pw-bot: cr