From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@suse.de>
Cc: "Ingo Molnar" <mingo@elte.hu>, <linux-kernel@vger.kernel.org>,
<discuss@x86-64.org>
Subject: Re: [PATCH 5/6, 2nd try] reliable stack trace support (i386)
Date: Mon, 22 May 2006 17:05:49 +0200 [thread overview]
Message-ID: <4471EF6D.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200605221613.57000.ak@suse.de>
>>> Andi Kleen <ak@suse.de> 22.05.06 16:13 >>>
>On Monday 22 May 2006 15:18, Jan Beulich wrote:
>> These are the i386-specific pieces to enable reliable stack traces. This is
>> going to be even more useful once CFI annotations get added to he assembly
>> code, namely to entry.S.
>
>Also obsolete with 6/6?
Yes, but I thought this basically just says that.
>> +#ifdef CONFIG_STACK_UNWIND
>> + . = ALIGN(4);
>> + .eh_frame : AT(ADDR(.eh_frame) - LOAD_OFFSET) {
>> + __start_unwind = .;
>> + *(.eh_frame)
>> + __end_unwind = .;
>> + }
>> +#endif
>
>Shouldn't this be CONFIG_UNWIND_INFO? Seems a bit unsymmetric to x86-64
It's exactly the same xor x86-64 - the added symbols (__start_unwind and __end_unwind) are only needed then. Of course,
there wouldn't be anything wrong if one used CONFIG_UNWIND_INFO here.
>I merged the patches all up for now. Thanks.
Thanks!
Jan
prev parent reply other threads:[~2006-05-22 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 13:18 Jan Beulich
2006-05-22 14:13 ` Andi Kleen
2006-05-22 15:05 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4471EF6D.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®