Randy.Dunlap wrote: > On Thu, 18 May 2006 10:49:36 -0500 Serge E. Hallyn wrote: > >> Replace references to system_utsname to the per-process uts namespace >> where appropriate. This includes things like uname. >> >> Changes: Per Eric Biederman's comments, use the per-process uts namespace >> for ELF_PLATFORM, sunrpc, and parts of net/ipv4/ipconfig.c >> >> Signed-off-by: Serge E. Hallyn >> >> --- >> >> 9ee063adf4d2287583dbb0a71d1d5f80d7ae011f >> diff --git a/arch/i386/kernel/sys_i386.c b/arch/i386/kernel/sys_i386.c >> index 8fdb1fb..4af731d 100644 >> --- a/arch/i386/kernel/sys_i386.c >> +++ b/arch/i386/kernel/sys_i386.c >> @@ -210,7 +210,7 @@ asmlinkage int sys_uname(struct old_utsn >> if (!name) >> return -EFAULT; >> down_read(&uts_sem); >> - err=copy_to_user(name, &system_utsname, sizeof (*name)); >> + err=copy_to_user(name, utsname(), sizeof (*name)); > > It would be really nice if you would fix spacing while you are here, > like a space a each side of '='. > > and a space after ',' in the function calls below. Here's a possible cleanup on top of serge's patchset as found in 2.6.17-rc4-mm3. C.