From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@infradead.org>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Anand Lodnoor <anand.lodnoor@broadcom.com>,
megaraidlinux.pdl@broadcom.com,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] scsi: megaraid_sas: simplify compat_ioctl handling
Date: Sat, 26 Sep 2020 21:52:29 -0700 [thread overview]
Message-ID: <4472b9ad60cde126e2098503665dfc35f8385992.camel@perches.com> (raw)
In-Reply-To: <CAK8P3a01930JPMj6ie=9+GtvRQThPzxH0_ge+OWydcZd7qRkSA@mail.gmail.com>
On Sat, 2020-09-26 at 23:19 +0200, Arnd Bergmann wrote:
> On Sat, Sep 19, 2020 at 7:26 AM Christoph Hellwig <hch@infradead.org> wrote:
> > On Fri, Sep 18, 2020 at 02:15:43PM +0200, Arnd Bergmann wrote:
[]
>
> > > + return ioc;
> > > +out:
> > > + kfree(ioc);
> > > +
> > > + return ERR_PTR(err);
> >
> > spurious empty line.
>
> ok
I suggest moving the blank line so it's between
the return ioc and out: label.
prev parent reply other threads:[~2020-09-27 4:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 12:09 [PATCH v2 1/3] scsi: aacraid: improve compat_ioctl handlers Arnd Bergmann
2020-09-18 12:15 ` [PATCH v2 2/3] scsi: megaraid_sas: check user-provided offsets Arnd Bergmann
2020-09-19 5:23 ` Christoph Hellwig
2020-09-18 12:15 ` [PATCH v2 3/3] scsi: megaraid_sas: simplify compat_ioctl handling Arnd Bergmann
2020-09-19 5:26 ` Christoph Hellwig
2020-09-26 21:19 ` Arnd Bergmann
2020-09-27 4:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4472b9ad60cde126e2098503665dfc35f8385992.camel@perches.com \
--to=joe@perches.com \
--cc=anand.lodnoor@broadcom.com \
--cc=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®