From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934463AbcLPIy2 (ORCPT ); Fri, 16 Dec 2016 03:54:28 -0500 Received: from foss.arm.com ([217.140.101.70]:48884 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934264AbcLPIyI (ORCPT ); Fri, 16 Dec 2016 03:54:08 -0500 Subject: Re: [PATCH v6 2/4] irqchip/qeic: merge qeic init code from platforms to a common function To: Qiang Zhao , "oss@buserror.net" , "tglx@linutronix.de" References: <1475033103-18192-1-git-send-email-qiang.zhao@nxp.com> <1475033103-18192-2-git-send-email-qiang.zhao@nxp.com> <45b9393b-bb29-4879-ee03-e4517b013e54@arm.com> Cc: "jason@lakedaemon.net" , Xiaobo Xie , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" From: Marc Zyngier Organization: ARM Ltd Message-ID: <44770f45-a949-80ea-107f-236be2f83f5d@arm.com> Date: Fri, 16 Dec 2016 08:54:05 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/12/16 08:43, Qiang Zhao wrote: > On 16/12/16 04:33, Marc Zyngier wrote: > >> -----Original Message----- >> From: Marc Zyngier [mailto:marc.zyngier@arm.com] >> Sent: Friday, December 16, 2016 4:33 PM >> To: Qiang Zhao ; oss@buserror.net; tglx@linutronix.de >> Cc: jason@lakedaemon.net; Xiaobo Xie ; linux- >> kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org >> Subject: Re: [PATCH v6 2/4] irqchip/qeic: merge qeic init code from platforms to >> a common function >> >> On 28/09/16 04:25, Zhao Qiang wrote: >>> The codes of qe_ic init from a variety of platforms are redundant, >>> merge them to a common function and put it to irqchip/irq-qeic.c >>> >>> For non-p1021_mds mpc85xx_mds boards, use "qe_ic_init(np, 0, >>> qe_ic_cascade_low_mpic, qe_ic_cascade_high_mpic);" instead of >>> "qe_ic_init(np, 0, qe_ic_cascade_muxed_mpic, NULL);". >>> >>> qe_ic_cascade_muxed_mpic was used for boards has the same interrupt >>> number for low interrupt and high interrupt, qe_ic_init has checked if >>> "low interrupt == high interrupt" >>> >>> Signed-off-by: Zhao Qiang >>> --- >>> Changes for v2: >>> - modify subject and commit msg >>> - add check for qeic by type >>> Changes for v3: >>> - na >>> Changes for v4: >>> - na >>> Changes for v5: >>> - na >>> Changes for v6: >>> - rebase >>> >>> arch/powerpc/platforms/83xx/misc.c | 15 --------------- >>> arch/powerpc/platforms/85xx/corenet_generic.c | 9 --------- >>> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 14 -------------- >>> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 16 ---------------- >>> arch/powerpc/platforms/85xx/twr_p102x.c | 14 -------------- >>> drivers/irqchip/irq-qeic.c | 16 ++++++++++++++++ >>> 6 files changed, 16 insertions(+), 68 deletions(-) >>> >> >> [...] >> >>> --- a/drivers/irqchip/irq-qeic.c >>> +++ b/drivers/irqchip/irq-qeic.c >>> @@ -598,4 +598,20 @@ static int __init init_qe_ic_sysfs(void) >>> return 0; >>> } >>> >>> +static int __init qeic_of_init(void) >>> +{ >>> + struct device_node *np; >>> + >>> + np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); >>> + if (!np) { >>> + np = of_find_node_by_type(NULL, "qeic"); >>> + if (!np) >>> + return; >>> + } >>> + qe_ic_init(np, 0, qe_ic_cascade_low_mpic, >>> + qe_ic_cascade_high_mpic); >>> + of_node_put(np); >>> +} >> >> Have you actually compiled that code? > > Yes. And the abundance of warnings that the compiler certainly spits doesn't strike you as an issue that should be addressed before posting the patches? Thanks, M. -- Jazz is not dead. It just smells funny...