From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035112AbdEZE1z (ORCPT ); Fri, 26 May 2017 00:27:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57712 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbdEZE1x (ORCPT ); Fri, 26 May 2017 00:27:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1D565612DE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v5 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1d0ed1858ae56c827bd09cc1fa6ff4a05d1530eb.1495720737.git.joabreu@synopsys.com> Cc: Carlos Palminha , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , David Airlie From: Archit Taneja Message-ID: <447f84c3-bd5f-760a-f33d-d7ee71276b16@codeaurora.org> Date: Fri, 26 May 2017 09:57:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1d0ed1858ae56c827bd09cc1fa6ff4a05d1530eb.1495720737.git.joabreu@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2017 07:49 PM, Jose Abreu wrote: > Now that we have a callback to check if bridge supports a given mode > we can use it in Analogix bridge so that we restrict the number of > probbed modes to the ones we can actually display. > > Also, there is no need to use mode_fixup() callback as mode_valid() > will handle the mode validation. > Reviewed-by: Archit Taneja > NOTE: Only compile tested. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Daniel Vetter > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Laurent Pinchart > Cc: David Airlie > --- > drivers/gpu/drm/bridge/analogix-anx78xx.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c > index a2a8236..cf69a1c 100644 > --- a/drivers/gpu/drm/bridge/analogix-anx78xx.c > +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c > @@ -1061,18 +1061,17 @@ static int anx78xx_bridge_attach(struct drm_bridge *bridge) > return 0; > } > > -static bool anx78xx_bridge_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +enum drm_mode_status anx78xx_bridge_mode_valid(struct drm_bridge *bridge, > + const struct drm_display_mode *mode) > { > if (mode->flags & DRM_MODE_FLAG_INTERLACE) > - return false; > + return MODE_NO_INTERLACE; > > /* Max 1200p at 5.4 Ghz, one lane */ > if (mode->clock > 154000) > - return false; > + return MODE_CLOCK_HIGH; > > - return true; > + return MODE_OK; > } > > static void anx78xx_bridge_disable(struct drm_bridge *bridge) > @@ -1129,7 +1128,7 @@ static void anx78xx_bridge_enable(struct drm_bridge *bridge) > > static const struct drm_bridge_funcs anx78xx_bridge_funcs = { > .attach = anx78xx_bridge_attach, > - .mode_fixup = anx78xx_bridge_mode_fixup, > + .mode_valid = anx78xx_bridge_mode_valid, > .disable = anx78xx_bridge_disable, > .mode_set = anx78xx_bridge_mode_set, > .enable = anx78xx_bridge_enable, > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project