From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbdJRNBC (ORCPT ); Wed, 18 Oct 2017 09:01:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33374 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbdJRNA6 (ORCPT ); Wed, 18 Oct 2017 09:00:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 47C7C1293 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [Part2 PATCH v5 31/31] KVM: X86: Restart the guest when insn_len is zero and SEV is enabled To: Brijesh Singh , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Borislav Petkov , Tom Lendacky References: <20171004131704.13266-1-brijesh.singh@amd.com> <20171004131704.13266-2-brijesh.singh@amd.com> <639d43f6-c403-4fff-7152-9814d9c5b9e6@amd.com> From: Paolo Bonzini Message-ID: <447f9182-c576-17e0-4bf7-9112e5e7c995@redhat.com> Date: Wed, 18 Oct 2017 15:00:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <639d43f6-c403-4fff-7152-9814d9c5b9e6@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 18 Oct 2017 13:00:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/2017 14:19, Brijesh Singh wrote: >> Is it needed to test mem_enc_enabled? Could it instead test for the >> availability of decode assists? > > We can use X86_FEATURE_DECODEASSIST but since mmu.c is common file hence > I was not sure if its safe for the VMX.  Is it okay to use decode assist > feature bit in mm.c ? See the follow up email. :) Paolo