From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E784C433E0 for ; Thu, 11 Feb 2021 05:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1796C64E26 for ; Thu, 11 Feb 2021 05:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbhBKFkg convert rfc822-to-8bit (ORCPT ); Thu, 11 Feb 2021 00:40:36 -0500 Received: from mailoutvs34.siol.net ([185.57.226.225]:47598 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229467AbhBKFkb (ORCPT ); Thu, 11 Feb 2021 00:40:31 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id BBBF7522F77; Thu, 11 Feb 2021 06:39:46 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zympFg3kgA5V; Thu, 11 Feb 2021 06:39:46 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id 71452521B94; Thu, 11 Feb 2021 06:39:46 +0100 (CET) Received: from jernej-laptop.localnet (cpe-86-58-58-53.static.triera.net [86.58.58.53]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 754F6522B31; Thu, 11 Feb 2021 06:39:43 +0100 (CET) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard , mturquette@baylibre.com, Stephen Boyd Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Andre Heider Subject: Re: [PATCH v3 1/5] clk: sunxi-ng: mp: fix parent rate change flag check Date: Thu, 11 Feb 2021 06:39:43 +0100 Message-ID: <44806885.xO3ZHcXyXd@jernej-laptop> In-Reply-To: <161301048085.1254594.6786751472945742937@swboyd.mtv.corp.google.com> References: <20210209175900.7092-1-jernej.skrabec@siol.net> <20210210102904.xyr6bftn4ueuu74z@gilmour> <161301048085.1254594.6786751472945742937@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne četrtek, 11. februar 2021 ob 03:28:00 CET je Stephen Boyd napisal(a): > Quoting Maxime Ripard (2021-02-10 02:29:04) > > > Hi Mike, Stephen, > > > > On Tue, Feb 09, 2021 at 06:58:56PM +0100, Jernej Skrabec wrote: > > > CLK_SET_RATE_PARENT flag is checked on parent clock instead of current > > > one. Fix that. > > > > > > Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when > > > allowed") Reviewed-by: Chen-Yu Tsai > > > Tested-by: Andre Heider > > > Signed-off-by: Jernej Skrabec > > > > This is a last minute fix for us, can you merge it into clk-fixes > > directly? > > > > Acked-by: Maxime Ripard > > It's also fixing a problem that's been around since v5.0. Is something > broken that needs fixing this late? The motivation could be added to the > commit text because right now it looks like a typo fix spotted visually. Yes, it's needed. Without this patch, 4k@60 doesn't work and probably some other resolutions too. That's why it's send with other display related fixes. This is part of solution for longstanding display issues. Best regards, Jernej