From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Nickey Yang <nickey.yang@rock-chips.com>,
<architt@codeaurora.org>, <airlied@linux.ie>
Cc: <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linux-rockchip@lists.infradead.org>, <dianders@chromium.org>,
<laurent.pinchart+renesas@ideasonboard.com>,
<joabreu@synopsys.com>, <andy.yan@rock-chips.com>,
<zhengyang@rock-chips.com>, <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode
Date: Mon, 20 Mar 2017 13:55:50 +0200 [thread overview]
Message-ID: <4484b511-5d89-4c46-3847-4f40ade79e98@mentor.com> (raw)
In-Reply-To: <1489978651-16647-1-git-send-email-nickey.yang@rock-chips.com>
Hi Nickey,
On 03/20/2017 04:57 AM, Nickey Yang wrote:
> "I2C Master Interface Extended Read Mode" implements a segment
> pointer-based read operation using the Special Register configuration.
>
> This patch fix https://patchwork.kernel.org/patch/7098101/ mentioned
> "The current implementation does not support "I2C Master Interface
> Extended Read Mode" to read data addressed by non-zero segment
> pointer, this means that if EDID has more than 1 extension blocks"
... EDID reading operation won't succeed.
Indeed.
>
> With this patch,dw-hdmi can read EDID data with 1/2/4 blocks.
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
Unfortunately I don't have a chance to test the change thoroughly, but
from what I see the implementation is correct. Thank you for the change.
Please feel free to update the commit message and add my
Acked-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2017-03-20 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 2:57 Nickey Yang
2017-03-20 11:13 ` Jose Abreu
2017-03-20 11:55 ` Vladimir Zapolskiy [this message]
2017-03-21 7:48 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4484b511-5d89-4c46-3847-4f40ade79e98@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=airlied@linux.ie \
--cc=andy.yan@rock-chips.com \
--cc=architt@codeaurora.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joabreu@synopsys.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nickey.yang@rock-chips.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=zhengyang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®