From: Sodagudi Prasad <psodagud@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>, gregkh@linuxfoundation.org
Cc: gregkh@linuxfoundation.org, juri.lelli@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity()
Date: Thu, 05 Oct 2017 18:40:23 -0700 [thread overview]
Message-ID: <44861c45841cc1dbc1ecac5df495ce35@codeaurora.org> (raw)
In-Reply-To: <20170925232019.GD3053@ubuntu>
On 2017-09-25 16:20, Viresh Kumar wrote:
> On 25-09-17, 15:51, Prasad Sodagudi wrote:
>> Remove the __init annotation from free_raw_capacity() to avoid
>> the following warning.
>>
>> The function init_cpu_capacity_callback() references the
>> function __init free_raw_capacity().
>> WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference
>> from the function init_cpu_capacity_callback() to the function
>> .init.text:free_raw_capacity().
>>
>> Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
>> ---
>> drivers/base/arch_topology.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/arch_topology.c
>> b/drivers/base/arch_topology.c
>> index 41be9ff..3da53cc 100644
>> --- a/drivers/base/arch_topology.c
>> +++ b/drivers/base/arch_topology.c
>> @@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)
>> static u32 capacity_scale;
>> static u32 *raw_capacity;
>>
>> -static int __init free_raw_capacity(void)
>> +static int free_raw_capacity(void)
>> {
>> kfree(raw_capacity);
>> raw_capacity = NULL;
>
> So we need the __init thing only when cpufreq support isn't there in
> the kernel
> and I am not sure if we want to add more ifdef hackery in the
> declaration of
> free_raw_capacity().
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Hi Greg,
Can you please consider this patch ?
-Thanks, Prasad
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-10-06 1:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 22:51 Prasad Sodagudi
2017-09-25 23:20 ` Viresh Kumar
2017-10-06 1:40 ` Sodagudi Prasad [this message]
2017-10-10 7:34 ` Prasad Sodagudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44861c45841cc1dbc1ecac5df495ce35@codeaurora.org \
--to=psodagud@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome