From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B45261B8F for ; Wed, 31 Dec 2025 10:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767178084; cv=none; b=CUA1ZelkTvYym1FK00jgdRygz7h0OdY/OwCVYw7wrRjxQCXZ7iQ/h0Zlg4BbjaSOchkBVbLgJmcMhv5TVNWWE4nV8dyu+quehJ2KFtSMqWjEasvfX7TOZty8JCu0whxkEPAgMhMIOb0a4a5a9tsXc/7pM45n3ibevirBjpJ1Z6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767178084; c=relaxed/simple; bh=aUhgaj0pGDvPj+sveRC4dkQqg4UJydEkIWaX/UF6/4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hdZ9N3VehP4A9hKsm6CNO3hVoi26bI74n5aaG3AO/2C8nUYisnFs0XdpZ0XPaoKZaHlZCkblYxoBV1duRhmChqBx5t0HFjRaQfn8dQCbPibBYd4YqdSARNFLXAQp24s6+pgsRwjxhqsBlCi1C8Zh6A+07t6STt5t+/uKRKDkFgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net; spf=pass smtp.mailfrom=pardini.net; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b=Cr64tRig; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pardini.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b="Cr64tRig" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-64b9d01e473so15165554a12.2 for ; Wed, 31 Dec 2025 02:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pardini.net; s=google; t=1767178080; x=1767782880; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F93O35PumyM940gks6WuFLpakwWFLPgJeDsUaIQB1m8=; b=Cr64tRiga08FEeRe1MSxFvD+oOwKV9aYnhSj2ZRAAG09BXl2LpHlCifkzsVLhJlDBL CGPp0tCawPOzWH6L9LEH78/WlPNkfdunD8m8qCY/x/sUprcuz42/UZc/ETWs9V1AemzW W67YVGINY+UpIz/h/OLZdXWetvYuLRE1pNya3p1ZVVHLjqCW5lDtn1Z1MXuhJoLS8e5L ajH3fVlyRPvC92oZeefrdBA8e0aYp+5BDTtjY6S5t3E3jqlW8HTc6+BMpP5xhmWUKSna SLDXzyJcMcIRyESBoUnIiW3/lgzx8nyLuRVE6ljLfCTelhK3nzyS93uW0mot8z8P1+oV KgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767178080; x=1767782880; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F93O35PumyM940gks6WuFLpakwWFLPgJeDsUaIQB1m8=; b=Bfmj+67+eTFAoTgaRqdF/5ZCcHm8HNcXFKqZXyDFkQinj+MBRBJulFPz5jQfdhDYxH AhXeBhVNRqFwWeIFJTazekIbFxsLC4/Moby9kombSH5LL0gtl3c+DGCt81IDTCR2EEvV cxQ9peixp2QxClHXSDbDeQrOhvpwGyBvlagUGAp9yHTK1moVyzyNr+9ieYiLPu7IP+8g m0Qajf4MZurX+CjW5P2UtVYUmUYNz4qaGcoXrSPp/MAyX7Whi7ZSaBldXFUhRr6dXQHy xl/kAtMZqY6WklIurLY4k3T7zcHtvYGML1lyHQBmiM2TFEG03pa545O26LNVXJTJ71pl eb3w== X-Forwarded-Encrypted: i=1; AJvYcCXY8sBx+7xJRtpAmM5JXzrXcUpxyrvS2XgQSXBgZBpUs9L9Xs/iBsFf7dVIJa7r0S+kFBXGb1dfZ4vrUT4=@vger.kernel.org X-Gm-Message-State: AOJu0YwdZurDEcuhiv+67VHddLhld7Ta1QNlORHckYycO6GBEYsHerGx AMMUvI8UDuVte6I2ILwjii8aV19866zAylb9LVZy3irlrvxFCtJY4N2n0BqS4S+48A== X-Gm-Gg: AY/fxX44ebt+fs3rqukVU2wevyZREGqUmrGdPkGUqQDyIQ4rN5er/Whe7ax/B1mJJjG GPgVBTD9IxuiV/CXA3HLMnnNABbNuGkZw8NTsYYyzh9iOhXJ3UaMpRj86ftx8TtkTcG4noZrGBf On8BnqYApe2KUtlFJ+XmbujqUkxQocBgtkdPT0Rfs1KMp76Nyavl9uJtg2Vsba3AHMgYVvuh15n UGPjQGF82Fncsm66LaymKw/7wbz3clZo6ZzkKLVsXvWubK8jZm/fdrO8tx1lIkwBNwOeUWTLF1c S4L/RVbmeSs5vNoqWkQcQev2Y76SRlZ5zINU51xnLiJn4sc7I6c/+sb1rkJa2SDPd5V8TVMB34+ leadyV5kTs8s4DuPV4wDeuxt47ADvy5ENNvF01n2vh7bKZQlMdOhuyyG+BclbLGmBYYPeE4zMHH qzUL+fdYTrGeeMwirkpmTAaQvGW43pCsgygPKqWzHTTnGk4sGpWVP3NrqGHlSftxwmPK25XWAbb Gi51u5zrK4NSMhKdkvi/zOhomdq82xC+fMnP6Vs36BfFlyTP+AuDQ8cfFJfStpSMXZA X-Google-Smtp-Source: AGHT+IF3qhSpzRRJ00xM16d/rHst6xExjWudsQHkK88MVOiMn97mRDN/nVNkVEeTmwCRmO4z98V2LA== X-Received: by 2002:a17:907:d64a:b0:b7c:e320:5232 with SMTP id a640c23a62f3a-b8036f0ae81mr3704046166b.5.1767178079658; Wed, 31 Dec 2025 02:47:59 -0800 (PST) Received: from ?IPV6:2a02:a466:4d7a:0:4db8:192e:8b05:7bd4? (2a02-a466-4d7a-0-4db8-192e-8b05-7bd4.fixed6.kpn.net. [2a02:a466:4d7a:0:4db8:192e:8b05:7bd4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8080e2177csm2948161966b.68.2025.12.31.02.47.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Dec 2025 02:47:59 -0800 (PST) Message-ID: <448acb0f-fa4d-45f1-83c1-7146cda9fc25@pardini.net> Date: Wed, 31 Dec 2025 11:47:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] arm64: dts: rockchip: Enable the NPU on some rk3588 boards To: Jimmy Hon Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.frattaroli@collabora.com References: <20251230-arm64-dts-rockchip-rk3588-npu-enablements-v1-0-d38b182a59e3@pardini.net> Content-Language: en-US From: Ricardo Pardini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jimmy, >> This series enables the NPU on a few Rockchip rk3588 boards. >> In every case here, the required regulator was already described. > Now that the pd_npu has defined the dependency to the vdd_npu_s0, > shouldn't the regulator-always-on be removed from the regulator? When > the Rock5B enabled the NPU, it didn't define the regulator with always > on. [1] > > More specifically, the commit message for the introduction of the > pd_npu label mentions how the regulator no longer needs to be always > on. [2] > > [1] https://lore.kernel.org/linux-rockchip/20250721-6-10-rocket-v9-10-77ebd484941e@tomeuvizoso.net/ > [2] https://lore.kernel.org/linux-rockchip/20250721-6-10-rocket-v9-7-77ebd484941e@tomeuvizoso.net/ Nice, I overlooked that. I'll send a v2 removing `regulator-always-on;` from the regulator. And maybe a separate series removing it from the the other NPU-enabled boards that still have it? Thanks, Ricardo