From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A93D5C433EF for ; Fri, 22 Oct 2021 15:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9306E6115B for ; Fri, 22 Oct 2021 15:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbhJVP1C (ORCPT ); Fri, 22 Oct 2021 11:27:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233358AbhJVP0w (ORCPT ); Fri, 22 Oct 2021 11:26:52 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0667DC061767; Fri, 22 Oct 2021 08:24:35 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 1D4241F44B70 Subject: Re: [PATCH v2 3/4] media: platform: mtk-mdp3: Set dma_set_mask_and_coherent To: "roy-cw.yeh" , Rob Herring , Matthias Brugger , Chun-Kuang Hu Cc: Mauro Carvalho Chehab , Fabien Parent , "jason-jh . lin" , daoyuan huang , Ping-Hsun Wu , Moudy Ho , "river . cheng" , Yongqiang Niu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20211022092827.24631-1-roy-cw.yeh@mediatek.com> <20211022092827.24631-4-roy-cw.yeh@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: <448b3d2f-54a0-f021-dc2a-ea29dc56c146@collabora.com> Date: Fri, 22 Oct 2021 17:24:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211022092827.24631-4-roy-cw.yeh@mediatek.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 22/10/21 11:28, roy-cw.yeh ha scritto: > From: "Roy-CW.Yeh" > > Use the dma_set_mask_and_coherent helper to set mdp > DMA bit mask to support 34bits iova space(16GB) that > the mt8195 iommu HW supports. > > The whole iova range separates to 0~4G/4G~8G/8G~12G/12G~16G. > Regarding which iova range mdp actually locates, > it depends on the dma-ranges property of mdp dtsi node. > > Signed-off-by: Roy-CW.Yeh Acked-by: AngeloGioacchino Del Regno > --- > drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c > index 12b029d145d6..51f7ef2b31ce 100644 > --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c > +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c > @@ -1141,6 +1141,9 @@ static int mdp_probe(struct platform_device *pdev) > mdp->pdev = pdev; > mdp->mdp_data = of_device_get_match_data(&pdev->dev); > > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > + > ret = of_property_read_u32(dev->of_node, "mediatek,mdp3-id", &id); > if (ret) { > dev_err(dev, "Failed to get mdp-id\n"); >