From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-91.mta1.migadu.com [95.215.58.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C313449988 for ; Sun, 11 Oct 2026 19:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791747606; cv=none; b=W0NP6ywF/QYhwNrFSrSDAiurIplg61gAQgvmOdvInK73wwhxsnEMVN9GerkwX4WSILcAuy8T10ui2fQHt1yN+vSRFOSrk0ssnMXnMhlrtLUduLjdfQnoDa8VdLYJW0yz9DvFSnEyyCp9gMOtKoaCLTf80hFiiaSaGg7ymoJVa3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791747606; c=relaxed/simple; bh=TqUJZt0jTQnNoDrW5bcG3O1AAOexFyLxL8nTiG2WsTo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bv/exuoKcQYkS9iIuj6azEAfiq+KRSjPaDLLvoTw+BNRd1eyruXWw+iilR1qJDaY5gaIOf2oyARSD0oluTh5MqCSkn/A7PgkvXs0f2DkZZC/7DO3ZdA1xwwu41mkke35jYpRMRBGk20GZDTFjiHImv/UIfD0CKG0CwM8LTsDqCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=B51q5m/L; arc=none smtp.client-ip=95.215.58.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="B51q5m/L" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=TqUJZt0jTQnNoDrW5bcG3O1AAOexFyLxL8nTiG2WsTo=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1791747602; v=1; x=1792352402; b=B51q5m/LYPYf8fZdQ1j4vhTIUixm2sJYzdVbq2Pa9T+9PqrWZLFv3HMrkBHIGBON/Yw/oes8 H5q9MTSsAeG4NQ+ajrP3tpnmx4WR6aCBF3oCjGNB9r1rBZ7N8LiLKUCJcyb7k+deI/WDwIMRSlh hy6Ttyb49YuHYvCfhy+JoMgI= X-Envelope-To: linux-kernel@vger.kernel.org Received: by mta11.migadu.com with ESMTPS id a578644b0269f23a; Sun, 11 Oct 2026 19:40:02 +0000 X-Mizu-Trace-ID: a578644b0269f23a X-Migadu-Flow: FLOW_OUT From: wen.yang@linux.dev To: Gabriele Monaco Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Wen Yang Subject: [PATCH v7 05/14] rv: Add a KUnit test for the storage free path Date: Mon, 12 Oct 2026 03:39:11 +0800 Message-Id: <448c421a47452ebddc6502ba3435eb91c1749601.1791745088.git.wen.yang@linux.dev> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wen Yang The test resolves a storage, desstroys it with da_destroy_storage(), and then arms the HA timer through the stale pointer. The free hook must disarm that timer too, so it never fires and no reaction is reported. Signed-off-by: Wen Yang --- kernel/trace/rv/rv_monitors_test.c | 38 ++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/kernel/trace/rv/rv_monitors_test.c b/kernel/trace/rv/rv_monitors_test.c index 889a209f6435..b30e49419e34 100644 --- a/kernel/trace/rv/rv_monitors_test.c +++ b/kernel/trace/rv/rv_monitors_test.c @@ -267,6 +267,43 @@ static void rv_test_rvtest_underflow(struct kunit *test) ha_cancel_timer_sync(ha_mon); } +/* + * rv_test_rvtest_arm_after_destroy - a storage outlived by its own timer + * + * da_destroy_storage() cancels the timer, then unlinks: + * + * da_monitor_reset_hook() cancels + * hash_del_rcu() + * call_rcu() + * + * A reader that resolved the storage before the unlink can arm past that + * cancel. Handlers resolve and use under one guard(rcu)(), so the two steps + * are issued separately here. + */ +static void rv_test_rvtest_arm_after_destroy(struct kunit *test) +{ + struct rv_kunit_ctx *ctx = test->priv; + const int id = 4242; + struct da_monitor *stale; + + prepare_test(test, &rvtest_mon); + + da_handle_start_run_event(id, NULL, start_rvtest); + + scoped_guard(rcu) /* resolve before the unlink */ + stale = da_get_monitor(id, NULL); + KUNIT_ASSERT_NOT_NULL(test, stale); + + da_destroy_storage(id); /* cancel, unlink, call_rcu */ + ha_start_timer_ns(to_ha_monitor(stale), clk_rvtest, + RVTEST_BUDGET_NS, ha_get_ns()); + + rcu_barrier(); + + msleep(600); + RV_KUNIT_EXPECT_NO_REACTION(test, ctx); +} + #include "monitors/sco/sco_kunit.c" #include "monitors/sssw/sssw_kunit.c" #include "monitors/sts/sts_kunit.c" @@ -285,6 +322,7 @@ static struct kunit_case rv_mon_test_cases[] = { KUNIT_CASE(rv_test_pagefault), KUNIT_CASE(rv_test_sleep), KUNIT_CASE(rv_test_rvtest_underflow), + KUNIT_CASE(rv_test_rvtest_arm_after_destroy), {} }; -- 2.25.1