From: Jianbo Liu <jianbol@nvidia.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Cosmin Ratiu <cratiu@nvidia.com>, Raed Salem <raeds@nvidia.com>,
Netdev <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [net-next] net/mlx5e: fix ip6_dst_lookup link failure
Date: Fri, 6 Feb 2026 19:45:02 +0800 [thread overview]
Message-ID: <448e9cf4-f31b-44ca-a352-916d53386843@nvidia.com> (raw)
In-Reply-To: <2ec67d1a-32ae-479e-99c2-dc5042d9f57e@app.fastmail.com>
On 2/6/2026 6:00 PM, Arnd Bergmann wrote:
> On Fri, Feb 6, 2026, at 10:56, Jianbo Liu wrote:
>> On 2/4/2026 9:00 PM, Arnd Bergmann wrote:
>>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>>> index 9cf394c66939..c298efe93f97 100644
>>> --- a/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Kconfig
>>> @@ -154,6 +154,7 @@ config MLX5_EN_IPSEC
>>> depends on MLX5_CORE_EN
>>> depends on XFRM_OFFLOAD
>>> depends on INET_ESP_OFFLOAD || INET6_ESP_OFFLOAD
>>> + depends on IPV6!=m || MLX5_CORE=m
>>
>> Thanks for the fix.
>> I received a report for this same error here:
>> https://lore.kernel.org/oe-kbuild-all/202512261850.P5Jp5BSz-lkp@intel.com/
>>
>> We were about to send a fix ourselves, it is to simply add:
>> depends on IPV6 || !IPV6
>> Is there a specific reason to prefer "depends on IPV6!=m ||
>> MLX5_CORE=m"? To me, the IPV6 || !IPV6 syntax seems a bit cleaner.
>
> MLX5_EN_IPSEC needs the dependency, but this is a 'bool' symbols.
>
> The "IPV6 || !IPV6" syntax only works on tristate symbols, so you'd
> have to put it into CONFIG_MLX5_CORE itself, but MLX5_CORE does
> not actually have the IPV6 dependency unless MLX5_EN_IPSEC is
> enabled.
>
Right, I meant moving the dependency to CONFIG_MLX5_CORE.
Your patch restricts only MLX5_EN_IPSEC, which causes the link error,
even if it silently disables IPsec in that specific config.
Acked-by: Jianbo Liu <jianbol@nvidia.com>
> Arnd
prev parent reply other threads:[~2026-02-06 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 13:00 Arnd Bergmann
2026-02-06 2:09 ` Jakub Kicinski
2026-02-06 9:56 ` [PATCH] " Jianbo Liu
2026-02-06 10:00 ` Arnd Bergmann
2026-02-06 11:45 ` Jianbo Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448e9cf4-f31b-44ca-a352-916d53386843@nvidia.com \
--to=jianbol@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®