Re: [PATCH 12/19] ASoC: codecs: wm2200: Propagate regcache_sync() errors

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 04/07/2026 5:00 am, Pengpeng Hou wrote:
> regcache_sync() can fail while replaying cached register state during
> runtime resume. wm2200_runtime_resume() currently ignores that failure.
> 
> Propagate the error, restore cache-only/dirty state, and unwind the LDO
> and core supplies acquired by runtime resume.
> 
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
>   sound/soc/codecs/wm2200.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/wm2200.c b/sound/soc/codecs/wm2200.c
> index ba8ce2e6e615..bc78b553b6cb 100644
> --- a/sound/soc/codecs/wm2200.c
> +++ b/sound/soc/codecs/wm2200.c
> @@ -2461,7 +2461,15 @@ static int wm2200_runtime_resume(struct device *dev)
>   	}
>   
>   	regcache_cache_only(wm2200->regmap, false);
> -	regcache_sync(wm2200->regmap);
> +	ret = regcache_sync(wm2200->regmap);
> +	if (ret) {
> +		regcache_cache_only(wm2200->regmap, true);
> +		regcache_mark_dirty(wm2200->regmap);
> +		gpiod_set_value_cansleep(wm2200->ldo_ena, 0);
> +		regulator_bulk_disable(ARRAY_SIZE(wm2200->core_supplies),
> +				       wm2200->core_supplies);
> +		return ret;
> +	}
>   
>   	return 0;
>   }

Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>