mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Indan Zupancic" <indan@nul.nu>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: "Jeremy Fitzhardinge" <jeremy@goop.org>,
	"Andi Kleen" <ak@suse.de>, "Andrey Borzenkov" <arvidjaar@mail.ru>,
	linux-kernel@vger.kernel.org, "Bernhard Walle" <bwalle@suse.de>
Subject: Re: [PATCH] x86: fix section mismatch warnings in mtrr
Date: Sat, 26 May 2007 14:07:24 +0200 (CEST)	[thread overview]
Message-ID: <4498.81.207.0.53.1180181244.squirrel@secure.samage.net> (raw)
In-Reply-To: <20070521151139.GA1929@uranus.ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]

On Mon, May 21, 2007 17:11, Sam Ravnborg wrote:
> On Mon, May 21, 2007 at 02:52:39PM +0100, Jeremy Fitzhardinge wrote:
>> Sam Ravnborg wrote:
>> > There was another patch that removed the __init marker to _fix_ section mismatch errors.
>> > I have lost the actual mail but I asked the submitter to send me a copy of
>> > the configuration so I could take a closer look.
>> > Obviously it was the wrong fix to remove the _init marker.
>>
>> Hm, I think there were two overlapping patches to address the problem.
>> One removed the __init markers, and was a bit of a hack.  Mine
>> restructured all the functions so that it was all done properly (ie,
>> init called init; cpuinit called cpuinit).  Looks like both got applied.
>
> OK, then all is good.

Did the patches reach 2.6.22-rc3 yet?

If they did, then the following warnings might need fixing:

WARNING: arch/i386/kernel/built-in.o(.text+0x84bc): Section mismatch: reference to
.init.text:amd_init_mtrr (between 'mtrr_bp_init' and 'mtrr_attrib_to_str')
WARNING: arch/i386/kernel/built-in.o(.text+0x84c1): Section mismatch: reference to
.init.text:cyrix_init_mtrr (between 'mtrr_bp_init' and 'mtrr_attrib_to_str')
WARNING: arch/i386/kernel/built-in.o(.text+0x84c6): Section mismatch: reference to
.init.text:centaur_init_mtrr (between 'mtrr_bp_init' and 'mtrr_attrib_to_str')
WARNING: arch/i386/kernel/built-in.o(.text+0x92d8): Section mismatch: reference to .init.text:
(between 'get_mtrr_state' and 'generic_get_mtrr')
WARNING: arch/i386/kernel/built-in.o(.text+0x92ef): Section mismatch: reference to .init.text:
(between 'get_mtrr_state' and 'generic_get_mtrr')
WARNING: arch/i386/kernel/built-in.o(.text+0x9313): Section mismatch: reference to .init.text:
(between 'get_mtrr_state' and 'generic_get_mtrr')

Config attached.

Greetings,

Indan

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 8128 bytes --]

  reply	other threads:[~2007-05-26 12:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-19 10:43 2.6.22-rc2: section mismatch Andrey Borzenkov
2007-05-19 11:00 ` Michal Piotrowski
2007-05-19 11:25   ` Andrey Borzenkov
2007-05-19 13:30     ` Indan Zupancic
2007-05-19 13:27 ` Sam Ravnborg
2007-05-19 13:32 ` [PATCH] x86: fix section mismatch warnings in mtrr Sam Ravnborg
2007-05-19 13:55   ` Andi Kleen
2007-05-19 14:09     ` Sam Ravnborg
2007-05-21 13:39     ` Jeremy Fitzhardinge
2007-05-21 13:48       ` Sam Ravnborg
2007-05-21 13:50         ` Sam Ravnborg
2007-05-21 13:52         ` Jeremy Fitzhardinge
2007-05-21 15:11           ` Sam Ravnborg
2007-05-26 12:07             ` Indan Zupancic [this message]
2007-05-26 16:02               ` Andi Kleen
2007-05-27  9:05                 ` Sam Ravnborg
2007-05-27  9:56                   ` Andi Kleen
2007-05-27 17:57                     ` Andrew Morton
2007-05-28 20:04                     ` Sam Ravnborg
2007-05-27 11:39                   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4498.81.207.0.53.1180181244.squirrel@secure.samage.net \
    --to=indan@nul.nu \
    --cc=ak@suse.de \
    --cc=arvidjaar@mail.ru \
    --cc=bwalle@suse.de \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome