From: Jeremy Fitzhardinge <jeremy@goop.org>
To: airlied@linux.ie
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Hourihane <alanh@fairlite.demon.co.uk>,
dri-devel@lists.sourceforge.net
Subject: i915 vsync interrupt fix
Date: Fri, 23 Jun 2006 17:36:46 -0700 [thread overview]
Message-ID: <449C891E.6010405@goop.org> (raw)
I need this patch from Alan Hourihane
<mailto:alanh@fairlite.demon.co.uk> to make direct rendering work
properly on my 945GM-based laptop. It comes from
https://bugs.freedesktop.org/show_bug.cgi?id=7233. This change is
immediately useful to me now, but I don't know if the development DRM is
going to be merged with the kernel any time soon (I notice CVS has a
variant of this patch).
J
/
/
From: Alan Hourihane <alanh@fairlite.demon.co.uk>
Look at vsync interrupts from pipe B as well as A.
https://bugs.freedesktop.org/show_bug.cgi?id=7233
diff -r 91a715ea44db drivers/char/drm/i915_irq.c
--- a/drivers/char/drm/i915_irq.c Thu Jun 22 19:09:11 2006 -0700
+++ b/drivers/char/drm/i915_irq.c Fri Jun 23 14:08:08 2006 -0700
@@ -44,7 +44,7 @@ irqreturn_t i915_driver_irq_handler(DRM_
u16 temp;
temp = I915_READ16(I915REG_INT_IDENTITY_R);
- temp &= (USER_INT_FLAG | VSYNC_PIPEA_FLAG);
+ temp &= (USER_INT_FLAG | VSYNC_PIPEA_FLAG | VSYNC_PIPEB_FLAG);
DRM_DEBUG("%s flag=%08x\n", __FUNCTION__, temp);
@@ -58,7 +58,7 @@ irqreturn_t i915_driver_irq_handler(DRM_
if (temp & USER_INT_FLAG)
DRM_WAKEUP(&dev_priv->irq_queue);
- if (temp & VSYNC_PIPEA_FLAG) {
+ if (temp & (VSYNC_PIPEA_FLAG | VSYNC_PIPEB_FLAG)) {
atomic_inc(&dev->vbl_received);
DRM_WAKEUP(&dev->vbl_queue);
drm_vbl_send_signals(dev);
@@ -197,7 +197,7 @@ void i915_driver_irq_postinstall(drm_dev
{
drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
- I915_WRITE16(I915REG_INT_ENABLE_R, USER_INT_FLAG | VSYNC_PIPEA_FLAG);
+ I915_WRITE16(I915REG_INT_ENABLE_R, USER_INT_FLAG | VSYNC_PIPEA_FLAG | VSYNC_PIPEB_FLAG);
DRM_INIT_WAITQUEUE(&dev_priv->irq_queue);
}
next reply other threads:[~2006-06-24 0:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-24 0:36 Jeremy Fitzhardinge [this message]
2006-06-24 5:25 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449C891E.6010405@goop.org \
--to=jeremy@goop.org \
--cc=airlied@linux.ie \
--cc=alanh@fairlite.demon.co.uk \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®