Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

[Thomas Zimmermann <tzimmermann@suse.de>]

[-- Attachment #1.1: Type: text/plain, Size: 2661 bytes --]

Hi

Am 09.04.21 um 15:50 schrieb Kevin Tang:
>      > +static int __init sprd_drm_init(void)
>      > +{
>      > +     int ret;
> 
>     I think ret should just go away.
> 
> Like this?
> "return platform_register_drivers(sprd_drm_drivers, 
> ARRAY_SIZE(sprd_drm_drivers));"

Sure.

Best regards
Thomas

> if so, i will fix it, thks.
> 
> 
>     Acked-by: Thomas Zimmermann <tzimmermann@suse.de
>     <mailto:tzimmermann@suse.de>>
> 
>      > +
>      > +     ret = platform_register_drivers(sprd_drm_drivers,
>      > +                                     ARRAY_SIZE(sprd_drm_drivers));
>      > +     return ret;
>      > +}
>      > +
>      > +static void __exit sprd_drm_exit(void)
>      > +{
>      > +     platform_unregister_drivers(sprd_drm_drivers,
>      > +                                 ARRAY_SIZE(sprd_drm_drivers));
>      > +}
>      > +
>      > +module_init(sprd_drm_init);
>      > +module_exit(sprd_drm_exit);
>      > +
>      > +MODULE_AUTHOR("Leon He <leon.he@unisoc.com
>     <mailto:leon.he@unisoc.com>>");
>      > +MODULE_AUTHOR("Kevin Tang <kevin.tang@unisoc.com
>     <mailto:kevin.tang@unisoc.com>>");
>      > +MODULE_DESCRIPTION("Unisoc DRM KMS Master Driver");
>      > +MODULE_LICENSE("GPL v2");
>      > diff --git a/drivers/gpu/drm/sprd/sprd_drm.h
>     b/drivers/gpu/drm/sprd/sprd_drm.h
>      > new file mode 100644
>      > index 000000000..9781fd591
>      > --- /dev/null
>      > +++ b/drivers/gpu/drm/sprd/sprd_drm.h
>      > @@ -0,0 +1,16 @@
>      > +/* SPDX-License-Identifier: GPL-2.0 */
>      > +/*
>      > + * Copyright (C) 2020 Unisoc Inc.
>      > + */
>      > +
>      > +#ifndef _SPRD_DRM_H_
>      > +#define _SPRD_DRM_H_
>      > +
>      > +#include <drm/drm_atomic.h>
>      > +#include <drm/drm_print.h>
>      > +
>      > +struct sprd_drm {
>      > +     struct drm_device drm;
>      > +};
>      > +
>      > +#endif /* _SPRD_DRM_H_ */
>      >
> 
>     -- 
>     Thomas Zimmermann
>     Graphics Driver Developer
>     SUSE Software Solutions Germany GmbH
>     Maxfeldstr. 5, 90409 Nürnberg, Germany
>     (HRB 36809, AG Nürnberg)
>     Geschäftsführer: Felix Imendörffer
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]