From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fei Shao <fshao@chromium.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: "Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Irui Wang" <irui.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Tiffany Lin" <tiffany.lin@mediatek.com>,
"Xiaoyong Lu" <xiaoyong.lu@mediatek.com>,
"Yunfei Dong" <yunfei.dong@mediatek.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 4/4] media: mediatek: vcodec: Drop VA check against mtk_vcodec_mem_free()
Date: Wed, 6 Dec 2023 11:19:32 +0100 [thread overview]
Message-ID: <449b9678-e3c2-4410-ac80-c50a1a25cc06@collabora.com> (raw)
In-Reply-To: <20231113123049.4117280-5-fshao@chromium.org>
Il 13/11/23 13:26, Fei Shao ha scritto:
> Now mtk_vcodec_mem_free() handles the VA-is-NULL case without generating
> excess error log, so we don't need to check that every time before using
> it in the driver.
>
> Remove all the unnecessary if branches against mtk_vcodec_mem_free().
>
> Signed-off-by: Fei Shao <fshao@chromium.org>
For the reasons explained in patch [3/4], I'd prefer to keep those checks.
Cheers,
Angelo
prev parent reply other threads:[~2023-12-06 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 12:26 [PATCH 0/4] Improvement around mtk_vcodec_mem_free() logging and usage Fei Shao
2023-11-13 12:26 ` [PATCH 1/4] media: mediatek: vcodec: Replace dev_name in error string Fei Shao
2023-12-06 10:19 ` AngeloGioacchino Del Regno
2023-11-13 12:26 ` [PATCH 2/4] media: mediatek: vcodec: Drop unnecessary variable Fei Shao
2023-12-06 10:19 ` AngeloGioacchino Del Regno
2023-12-07 11:14 ` Fei Shao
2023-11-13 12:26 ` [PATCH 3/4] media: mediatek: vcodec: Fix mtk_vcodec_mem_free() error log criteria Fei Shao
2023-12-06 10:19 ` AngeloGioacchino Del Regno
2023-12-07 11:17 ` Fei Shao
2023-12-07 12:54 ` AngeloGioacchino Del Regno
2023-12-08 4:22 ` Fei Shao
2023-11-13 12:26 ` [PATCH 4/4] media: mediatek: vcodec: Drop VA check against mtk_vcodec_mem_free() Fei Shao
2023-12-06 10:19 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449b9678-e3c2-4410-ac80-c50a1a25cc06@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=dan.carpenter@linaro.org \
--cc=fshao@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nfraprado@collabora.com \
--cc=nicolas.dufresne@collabora.com \
--cc=tiffany.lin@mediatek.com \
--cc=xiaoyong.lu@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®