mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Feix <michal.feix@firma.seznam.cz>
To: Paul.Clements@steeleye.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] nbd: Abort request on data reception failure
Date: Sun, 16 Jul 2006 15:17:12 +0200	[thread overview]
Message-ID: <44BA3C58.5080708@firma.seznam.cz> (raw)

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

When reading from nbd device, we need to receive all the data after
receiving reply packet from the server - otherwise such request will
never be ended.

If socket is closed right after accepting reply control packet and in
the middle of waiting for read data, nbd_read_stat() returns NULL and
nbd_end_request() is not called.

This patch fixes it.

Signed-off-by: Michal Feix <michal@feix.cz>
---


[-- Attachment #2: nbd.c.always-end-request.diff --]
[-- Type: text/plain, Size: 569 bytes --]

diff -upr 2.6.18-rc2.orig/drivers/block/nbd.c 2.6.18-rc2/drivers/block/nbd.c
--- 2.6.18-rc2.orig/drivers/block/nbd.c	2006-07-16 15:08:07.866293000 +0200
+++ 2.6.18-rc2/drivers/block/nbd.c	2006-07-16 15:08:55.361261250 +0200
@@ -339,7 +339,8 @@ static struct request *nbd_read_stat(str
 					printk(KERN_ERR "%s: Receive data failed (result %d)\n",
 							lo->disk->disk_name,
 							result);
-					goto harderror;
+					req->errors++;
+					return req;
 				}
 				dprintk(DBG_RX, "%s: request %p: got %d bytes data\n",
 					lo->disk->disk_name, req, bvec->bv_len);

             reply	other threads:[~2006-07-16 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-16 13:17 Michal Feix [this message]
2006-07-17 15:26 ` Paul Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BA3C58.5080708@firma.seznam.cz \
    --to=michal.feix@firma.seznam.cz \
    --cc=Paul.Clements@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®