From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: Panagiotis Issaris <takis@gna.org>,
Jeff Garzik <jgarzik@pobox.com>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Panagiotis Issaris <takis@lumumba.uhasselt.be>,
linux-kernel@vger.kernel.org, len.brown@intel.com,
chas@cmf.nrl.navy.mil, miquel@df.uba.ar, kkeil@suse.de,
benh@kernel.crashing.org, video4linux-list@redhat.com,
rmk+mmc@arm.linux.org.uk, Neela.Kolli@engenio.com,
vandrove@vc.cvut.cz, adaplas@pol.net, thomas@winischhofer.net,
weissg@vienna.at, philb@gnu.org,
linux-pcmcia@lists.infradead.org, jkmaline@cc.hut.fi,
paulus@samba.org
Subject: Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.
Date: Fri, 21 Jul 2006 16:08:25 +0200 [thread overview]
Message-ID: <44C0DFD9.1040609@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0607211409540.27644@sbz-30.cs.Helsinki.FI>
Pekka J Enberg wrote:
> On Fri, 21 Jul 2006, Stefan Richter wrote:
>> Contributors can't know what the (supposed) _agreements_ are.
>>
>> Contributors can only know what the _documented conventions_ are.
>
> Life gets easier when you accept the fact that there are different
> conventions within the kernel, driven by maintainer preference. Which is
> why it is impossible to document a definite set of conventions too.
> CodingStyle really is just a good approximation
[...]
What can a contributor do when he comes across code which deviates from
CodingStyle? He cannot tell whether the initial developer wasn't forced
to adhere to CodingStyle or the maintainer wants it that way. So, the
contributor
- could ask the maintainer for his ruleset before writing a patch, or
- could simply write the patch and wait if the maintainer feels need to
demand adjustments.
I am not sure which strategy will consume less time of contributor and
maintainer.
--
Stefan Richter
-=====-=-==- -=== =--==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-07-21 14:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-20 19:05 [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc Panagiotis Issaris
2006-07-21 6:50 ` Rolf Eike Beer
2006-07-21 6:58 ` Pekka Enberg
2006-07-21 7:05 ` Jeff Garzik
2006-07-21 9:09 ` Stefan Richter
2006-07-21 10:20 ` Jesper Juhl
2006-07-21 10:35 ` Panagiotis Issaris
2006-07-21 10:38 ` Pekka J Enberg
2006-07-21 10:55 ` Stefan Richter
2006-07-22 17:58 ` Tomasz Kłoczko
2006-07-22 18:25 ` Stefan Richter
2006-07-22 18:35 ` Tomasz Kłoczko
2006-07-22 20:02 ` Jeff Garzik
2006-07-22 20:55 ` Tomasz Kłoczko
2006-07-23 11:20 ` Alexey Dobriyan
2006-07-23 17:55 ` Tomasz Kłoczko
2006-07-23 18:24 ` Michael Buesch
2006-07-24 0:10 ` Tomasz Kłoczko
2006-07-24 0:49 ` Tomasz Kłoczko
2006-07-24 8:03 ` Lindent cleanup (was Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.) Stefan Richter
2006-07-24 8:52 ` Tomasz Kłoczko
2006-07-23 15:16 ` [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc Stefan Richter
2006-07-23 18:09 ` Tomasz Kłoczko
2006-07-21 10:53 ` Stefan Richter
2006-07-21 11:09 ` Stefan Richter
2006-07-21 21:16 ` Jeff Garzik
2006-07-21 21:15 ` Jeff Garzik
2006-07-22 6:20 ` Stefan Richter
2006-07-21 9:32 ` [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc Panagiotis Issaris
2006-07-21 10:14 ` Pekka J Enberg
2006-07-21 10:42 ` Panagiotis Issaris
2006-07-21 11:02 ` Stefan Richter
2006-07-21 11:20 ` Pekka J Enberg
2006-07-21 14:08 ` Stefan Richter [this message]
2006-07-21 21:17 ` Jeff Garzik
2006-07-21 10:21 ` [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc Daniel K.
2006-07-21 10:30 ` Panagiotis Issaris
2006-07-21 11:12 ` Rolf Eike Beer
2006-07-21 12:35 ` Dmitry Torokhov
2006-07-21 12:39 ` Panagiotis Issaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44C0DFD9.1040609@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=Neela.Kolli@engenio.com \
--cc=adaplas@pol.net \
--cc=benh@kernel.crashing.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=eike-kernel@sf-tec.de \
--cc=jgarzik@pobox.com \
--cc=jkmaline@cc.hut.fi \
--cc=kkeil@suse.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=miquel@df.uba.ar \
--cc=paulus@samba.org \
--cc=penberg@cs.Helsinki.FI \
--cc=philb@gnu.org \
--cc=rmk+mmc@arm.linux.org.uk \
--cc=takis@gna.org \
--cc=takis@lumumba.uhasselt.be \
--cc=thomas@winischhofer.net \
--cc=vandrove@vc.cvut.cz \
--cc=video4linux-list@redhat.com \
--cc=weissg@vienna.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome