From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: nhorman@tuxdriver.com
Cc: bcollins@debian.org, kernel-janitors@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [KJ] audit return code handling for kernel_thread [8/11]
Date: Sat, 29 Jul 2006 18:17:52 +0200 [thread overview]
Message-ID: <44CB8A30.2080809@s5r6.in-berlin.de> (raw)
In-Reply-To: <200607282007.k6SK7v9j009670@ra.tuxdriver.com>
nhorman@tuxdriver.com wrote:
> --- a/drivers/ieee1394/nodemgr.c
> +++ b/drivers/ieee1394/nodemgr.c
> @@ -426,7 +426,8 @@ static ssize_t fw_set_rescan(struct bus_
> * something stupid and spawn this a lot of times, but that's
> * root's fault. */
> if (state == 1)
> - kernel_thread(nodemgr_rescan_bus_thread, NULL, CLONE_KERNEL);
> + if (kernel_thread(nodemgr_rescan_bus_thread, NULL, CLONE_KERNEL) < 0)
> + printk(KERN_WARNING "Could not start 1394 bus rescan thread\n");
>
> return count;
> }
Thanks, but (a) we don't need the warnig and (b) we even don't need to
spawn a thread at this point. This call to kernel_thread has been
removed from git-ieee1394 and -mm earlier this month.
http://www.kernel.org/git/?p=linux/kernel/git/bcollins/linux1394-2.6.git;a=commitdiff_plain;h=40fd89cc54a8a67c81b5aa40b22c4f40b39e47b9
http://marc.theaimsgroup.com/?l=linux-mm-commits&m=115189722112717
--
Stefan Richter
-=====-=-==- -=== ===-=
http://arcgraph.de/sr/
prev parent reply other threads:[~2006-07-29 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 20:07 nhorman
2006-07-29 16:17 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44CB8A30.2080809@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=bcollins@debian.org \
--cc=kernel-janitors@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®