From: "Jan Beulich" <jbeulich@novell.com>
To: "Andi Kleen" <ak@muc.de>
Cc: "Andreas Kleen" <ak@suse.de>, <linux-kernel@vger.kernel.org>,
<discuss@x86-64.org>
Subject: Re: [PATCH] fix x86 cpuid keys used in alternative_smp()
Date: Wed, 16 Aug 2006 08:28:39 +0200 [thread overview]
Message-ID: <44E2D737.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20060815182145.6dc74c63.ak@muc.de>
>> By hard-coding the cpuid keys for alternative_smp() rather than using
>> the symbolic constant it turned out that incorrect values were used on
>> both i386 (0x68 instead of 0x69) and x86-64 (0x66 instead of 0x68).
>
>Thanks. Applied.
>
>I wonder if that was the reason why the .fill misassembly the
>2.16.91.0.5 (10.1) binutils commits (see recent discuss report from
>Rafael) didn't cause crashes on UP machines. Do you have
>an opinion on that?
That is well possible - I saw the mail, and I also wondered why this
wouldn't result in a broken kernel.
Jan
prev parent reply other threads:[~2006-08-16 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 16:03 Jan Beulich
2006-08-15 16:21 ` Andi Kleen
2006-08-16 6:28 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E2D737.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@muc.de \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome