From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965052AbWH2QKV (ORCPT ); Tue, 29 Aug 2006 12:10:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965050AbWH2QKV (ORCPT ); Tue, 29 Aug 2006 12:10:21 -0400 Received: from hp3.statik.TU-Cottbus.De ([141.43.120.68]:21894 "EHLO hp3.statik.tu-cottbus.de") by vger.kernel.org with ESMTP id S965044AbWH2QKT (ORCPT ); Tue, 29 Aug 2006 12:10:19 -0400 Message-ID: <44F465F6.6040202@s5r6.in-berlin.de> Date: Tue, 29 Aug 2006 18:06:14 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.5) Gecko/20060721 SeaMonkey/1.0.3 MIME-Version: 1.0 To: Alan Stern CC: Andrew Morton , Ingo Molnar , Kernel development list , SCSI development list , Jens Axboe Subject: Re: [PATCH 0/4] Change return values from queue_work et al. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Alan Stern wrote: ... > Note that the change falls within the bounds of the documented > behavior, in the sense that any code which was originally written > correctly (i.e., in accordance with the documentation) will continue to > work correctly without generating any warnings. ... You are right that there is no comment (or better yet, kerneldoc comment) about what happens if an instance of work_struct is enqueued twice. However, /a/ there is the source and /b/ Corbet, Rubini, Kroah-Hartman: LDD3 describes in detail in an easily understood section how workqueues are to be used. (Workqueues in Linux 2.6.10, that is.) ... > If the > usage is correct then there is no harm in leaving the WARN_ON call where > it is. If the usage is wrong then the call needs to be fixed, and the > maintainer for the subsystem containing the call will soon find out about > it, thanks to the WARN_ON. ... Acceptable on second thought, particularly in light of your new replacement functions with improved semantics of their return value. Although there are cases where the WARN_ON might not go off during a long time, or where an update won't happen in many months despite hundreds of reports at dozens of mailing lists and bugzillas. -- Stefan Richter -=====-=-==- =--- ===-= http://arcgraph.de/sr/