mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kyle Moffett <mrmacman_g4@mac.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Hirokazu Takata <takata@linux-m32r.org>,
	torvalds@odsl.org, linux-kernel@vger.kernel.org,
	sam@ravnborg.org
Subject: Re: [PATCH] m32r: set CHECKFLAGS properly
Date: Tue, 27 Sep 2005 13:31:25 -0400	[thread overview]
Message-ID: <44F9E519-C94E-422B-9CA7-B24C2F76B78D@mac.com> (raw)
In-Reply-To: <20050927163455.GT7992@ftp.linux.org.uk>

On Sep 27, 2005, at 12:34:55, Al Viro wrote:
> *Hell*, no.
>     1) any use of cross-gcc is immediately b0rken
>     2) anything like building i386 on amd64 (native toolchain, -m32  
> in arguments) is b0rken

So s/gcc/$(SOME_MAKEFILE_VARIABLE)/g  I was simplifying for the sake  
of suggestion/example; adding in support for all of those is  
nontrivial and best left to those who thoroughly understand the  
kernel Makefile system (IE: Not me :-D).

>     3) way, way, *WAY* too much spew.  gcc pre-defines shitloads of  
> stuff and some of that stuff very definitely should not be there  
> for sparse.

Why not?  Some of that stuff may get used in kernel headers, which  
sparse should definitely have defined.  Besides, sparse is designed  
to check C source code, which will be compiled with said GCC using  
those preprocessing defines.  Why should it use a different set of  
defines?

> IOW, it's not that simple.  You need final CC, CFLAGS and CPPFLAGS  
> for that.

See responses to (1) and (2)

> Moreover, your variant won't do at all - change .config and you  
> might need to rebuild that file on biarch platforms (parisc and  
> s390 at the very least; ppc/ppc64 are also moving in that direction).

We do far worse messes in per-arch Makefiles, and this seems  
reasonably easy to put in an arch-generic makefile, unless there is  
some significant complication you didn't mention.

Cheers,
Kyle Moffett

--
I have yet to see any problem, however complicated, which, when you  
looked at it in the right way, did not become still more complicated.
   -- Poul Anderson




  reply	other threads:[~2005-09-27 17:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-26  5:18 Al Viro
2005-09-27  6:13 ` Hirokazu Takata
2005-09-27  7:10   ` Al Viro
2005-09-27 15:13     ` Kyle Moffett
2005-09-27 16:34       ` Al Viro
2005-09-27 17:31         ` Kyle Moffett [this message]
2005-09-27 17:55           ` Al Viro
2005-09-27 18:37             ` Kyle Moffett
2005-09-27 23:06               ` Al Viro
2005-09-27 20:02     ` Sam Ravnborg
2005-09-28  1:44       ` Al Viro
2005-09-27  6:23 ` Hirokazu Takata
2005-09-27 15:00   ` Linus Torvalds
2005-09-28  0:18     ` Al Viro
2005-09-28 10:04       ` Hirokazu Takata
2005-09-29  1:56         ` Al Viro
2005-09-26  5:19 Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F9E519-C94E-422B-9CA7-B24C2F76B78D@mac.com \
    --to=mrmacman_g4@mac.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=takata@linux-m32r.org \
    --cc=torvalds@odsl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®