From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753524AbdHULxF (ORCPT <rfc822;w@1wt.eu>);
        Mon, 21 Aug 2017 07:53:05 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:55704 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752234AbdHULxE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 21 Aug 2017 07:53:04 -0400
Subject: Re: [PATCH v2] irqchip: uniphier-aidet: add UniPhier AIDET irqchip
 driver
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Randy Dunlap <rdunlap@infradead.org>, devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
References: <1503309663-2742-1-git-send-email-yamada.masahiro@socionext.com>
 <e3b865f5-a779-f176-67ef-9ffac25019d4@arm.com>
 <CAK7LNAS_bTsweGB-WqbSoh8myTET9KW-7oN0FLZTmAf_K317aw@mail.gmail.com>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <44a166ec-019e-8f84-5469-b095eb4d26fe@arm.com>
Date: Mon, 21 Aug 2017 12:53:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAK7LNAS_bTsweGB-WqbSoh8myTET9KW-7oN0FLZTmAf_K317aw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21/08/17 11:54, Masahiro Yamada wrote:

>>> +     /* parent is GIC */
>>> +     parent_fwspec.fwnode = domain->parent->fwnode;
>>> +     parent_fwspec.param_count = 3;
>>> +     parent_fwspec.param[0] = 0;             /* SPI */
>>> +     parent_fwspec.param[1] = hwirq;
>>> +     parent_fwspec.param[2] = IRQ_TYPE_LEVEL_HIGH;   /* properly set later */
>>
>> Why defer it to later? You already have the right information in "type",
>> so you might as well provide it immediately.
> 
> 
> Because .irq_set_type() will set it up
> before the IRQ is really in use.
> 
> 
> If we look gic_irq_domain_alloc() implementation,
> it does not care "type".
> 
> gic_set_type() will manipulate hardware registers.

But that's out of the scope of this driver. Whatever the GIC driver does
(or doesn't), you should pass it the right information.

> Having said that, it shouldn't hurt to set type here.
Exactly.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...