From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C112ECAAD8 for ; Thu, 22 Sep 2022 01:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbiIVBy1 (ORCPT ); Wed, 21 Sep 2022 21:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbiIVByX (ORCPT ); Wed, 21 Sep 2022 21:54:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A1DA99EA for ; Wed, 21 Sep 2022 18:54:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2778F62E03 for ; Thu, 22 Sep 2022 01:54:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E545C433D6; Thu, 22 Sep 2022 01:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663811660; bh=daKmN7uJuDeH1R9QVXhts08inJKQ5l61NyNLAVl0mw8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=P2BbwMgGbIs43cgBkNNo0FkR8WQutLBQUetMagrS+69fFNB11WgGFnCchJ3YWd3c1 jvhTnp5j4u6fQrPODLUgmdpe3VdY0S8vexR7eoQbKpMy++YSfAhoPi1vSBdwCO7M3D qPkZPQ/5MnRy1KoUJL13g39/9HY8rKPWA7PftAYKIGNIAMgcD2wQREmlIk/Y7oT6ci JGMgDxaIpd75TtxD/xz7E5aenj2kwR6ftOvRVnVtgD4P2/ilCOISRSyAFoM6A8DEur TOvX33449C40W6rKb3q7kYC0ETljarGWcl/rOI6JFIfi7e8nUV9QJitfmAGQpZb3ps RiCY75RhVNw8A== Message-ID: <44a1eca6-568b-a752-ef01-06de489eb466@kernel.org> Date: Thu, 22 Sep 2022 09:54:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3] f2fs: fix to detect corrupted meta ino Content-Language: en-US To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20220913074812.2300528-1-chao@kernel.org> From: Chao Yu In-Reply-To: <20220913074812.2300528-1-chao@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping, On 2022/9/13 15:48, Chao Yu wrote: > It is possible that ino of dirent or orphan inode is corrupted in a > fuzzed image, occasionally, if corrupted ino is equal to meta ino: > meta_ino, node_ino or compress_ino, caller of f2fs_iget() from below > call paths will get meta inode directly, it's not allowed, let's > add sanity check to detect such cases. > > case #1 > - recover_dentry > - __f2fs_find_entry > - f2fs_iget_retry > > case #2 > - recover_orphan_inode > - f2fs_iget_retry > > Signed-off-by: Chao Yu > --- > v3: > - update commit title/message > - change logic inside f2fs_iget() rather than its caller > fs/f2fs/inode.c | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index cde0a3dc80c3..1baac6056733 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -487,6 +487,12 @@ static int do_read_inode(struct inode *inode) > return 0; > } > > +static bool is_meta_ino(struct f2fs_sb_info *sbi, unsigned int ino) > +{ > + return ino == F2FS_NODE_INO(sbi) || ino == F2FS_META_INO(sbi) || > + ino == F2FS_COMPRESS_INO(sbi); > +} > + > struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > { > struct f2fs_sb_info *sbi = F2FS_SB(sb); > @@ -497,17 +503,22 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > if (!inode) > return ERR_PTR(-ENOMEM); > > + if (is_meta_ino(sbi, ino)) { > + if (!(inode->i_state & I_NEW)) { > + f2fs_err(sbi, "detect corrupted inode no:%lu, run fsck to repair", ino); > + set_sbi_flag(sbi, SBI_NEED_FSCK); > + ret = -EFSCORRUPTED; > + trace_f2fs_iget_exit(inode, ret); > + iput(inode); > + return ERR_PTR(ret); > + } > + goto make_now; > + } > + > if (!(inode->i_state & I_NEW)) { > trace_f2fs_iget(inode); > return inode; > } > - if (ino == F2FS_NODE_INO(sbi) || ino == F2FS_META_INO(sbi)) > - goto make_now; > - > -#ifdef CONFIG_F2FS_FS_COMPRESSION > - if (ino == F2FS_COMPRESS_INO(sbi)) > - goto make_now; > -#endif > > ret = do_read_inode(inode); > if (ret)