From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561Ab2DBRBe (ORCPT ); Mon, 2 Apr 2012 13:01:34 -0400 Received: from host171.canaca.com ([67.55.55.225]:39155 "EHLO host171.canaca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498Ab2DBRBc (ORCPT ); Mon, 2 Apr 2012 13:01:32 -0400 Message-ID: <44acbf3ff0b6aa62eab2831ee6ecea80.squirrel@mungewell.org> In-Reply-To: <4F79D486.5090605@suse.cz> References: <1333378444-3117-1-git-send-email-simon@mungewell.org> <4F79D486.5090605@suse.cz> Date: Mon, 2 Apr 2012 13:01:30 -0400 Subject: Re: [PATCH 1/2] HID: hid-lg4ff: Use Private Data From: simon@mungewell.org To: "Jiri Slaby" Cc: "Simon Wood" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Kosina" , "Michael Bauer" , "Michal Maly" User-Agent: SquirrelMail/1.4.21 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host171.canaca.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mungewell.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> + struct lg4ff_device_entry *uninitialized_var(entry); >> + struct lg_drv_data *uninitialized_var(drv_data); > > You don't need uninitialized_var bloat anymroe, right? I guess I don't fully understand the 'unitialized_var()' macro, and was just following the previous uses in the code. Google'ing doesn't really help either. Is there a definitive guide as when to use and not? Simon