From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 625BA301465 for ; Fri, 27 Feb 2026 09:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772185676; cv=none; b=E4KVOm43kXlkFGZWjP5VOGUK73hV7r8RDEg7P++hb+E64VIQc7RWaeRRvBCxOKde/ZaSBYCdiFL0mQ18QW5mcNt3qjtRCQ/TvLSx62XreRWFdjqzgQWMnLOdb4WrBvJdTX+Nky+zTaV8sQS7O2zDM3jLkfsHpj77otTGji2Tavc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772185676; c=relaxed/simple; bh=sDqOLIElO9sU72I8htWWTt5yNo0GEDCaewrWX4E83eY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mCh2UZnpln94c8rCkEcZRWRDpgxO0VzYGBWgy0EFLhmv/qXvitlmWpaWYbdiZP4ksN9YoXbKtBT6V+zoThmC5svvzh9V5aB/Vl1GwcsZP8nZxzOQdmxvw7i5lphRSihbp0Yy1jzGrBYhAOfTm+t7Tp1InPhnqScO6WkxmjVJQTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tawCJQB7; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tawCJQB7" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43988056dc3so1823419f8f.3 for ; Fri, 27 Feb 2026 01:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772185674; x=1772790474; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lvnzu0nnoktPCLf+OVvM4xkOpLiznX3KsepjyKiu5SE=; b=tawCJQB7tfggauC1TSg88aUG+pHpHclM53cndGvlsNz4NrQFs+I8UCJ6GdHKqx1RxV 1vYSwGL77XHCQ9nvDrjllPg+fZR40XhHT/7xy9C2VX6STF7BGecOD2BFsLTYHISicTp8 N5HU1APBIzVCrmscvO2TYfTAoliRtvLbOWqy97VzFUtRJbiU6YaesbL3BevcMGxWCFbj XIYBXRWtbBQW1tin9nNbI5u6CTGmXy4Qwtf7fk1zq6EsI+Cs72AJopDgWKfQuAV2eCq9 2E4Qhl1MnJp++sI0MKAiy5xz6oK/cqKdkh10Tc5OUgPMnAmY0pGLg8y7IBA1zEe7BJPX Ercw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772185674; x=1772790474; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lvnzu0nnoktPCLf+OVvM4xkOpLiznX3KsepjyKiu5SE=; b=n5Ej1Mj9f6/lE8SoKZWJ8X98kV4CCFrG2QJy7ffV4DIjPLv3rmFFodpeqAn7rX9Hrd 2fjIES6OI6bQ2+fj4l3xRHpACNSX9LJHaM/ErF4UJCh5fsyYiiKziw4lZ3RkjroNa3at NbkVTN73vjQmcXxC7yNXd3NMd1gKcLdtkrnn74xfQYpXGfVdlo5OC/gdUY8RoT7QZvSd t/EStAWBEhRLDY0z6T2YsAnkC0Bok+GEJdKw8yOfjtD07QucLn7IfOAwgon9cLXhxNMV QMt9VwRuD+FqJrjXts3oiOG3VN50vAKM4ZQibFhZPRpi5d7cKWNFra4+x2MGea0gF3om R8AA== X-Forwarded-Encrypted: i=1; AJvYcCVhGQ/zW7naiPC8AMqCWTBFb/MDlelZDdXegtyRbgisQVCX5X4E3esqEdzI2CGocgZROXFaJimJughUIzI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxe505hjNkkHVwjvX/A8+x1aiwPqy8REpyOlG+87kd89LizL3Gx ZZQcz6jfVW5qn+3jyvlfSHTaZN6ZT+VqWNSYRd9qFbX+Ss57BWSapP3FctMUnk8lri4= X-Gm-Gg: ATEYQzwvROErLe/7b1bFa4Zx63ARtTlywBfVyXUWr3KZe4Z4it2zOC0yMUpONBwQJSJ i6afU94SO3I0Kn6ZEhEkK3DYW/Vit//0UbbdBqLbIhRurGiF/tAwPXHwUyFrnIK3yR0RStmeM4E TD/GlxLRxTJKLbKaUd4AKl+1wb1nPJwKeLHA1Y/v1SUAGk70jK89I6mdSUQrtvf3C8cqJBIuclO VFjn6hUHIiB5zR3ueRSwZnZMiDx2sPDsXVGhnIa0T+kLQKyRnjIEXgSSgrbEiyMHaiJLpwZ9u0V Yi9pStNobJu/es9Rlfiw//dhLb5BGHzirwOxAFBQCRr3zo+Zgjqer0lY2Zt++I8u+PvAPTRuRoC 3Lpxb0AmeA9Vs6eGBUSxmap2Ug2p0mRD9XIxsM5Kya+c1Dy/tVUZHr7fGO2966a7uSYZbqeV/n1 uNX3Ko6n1Eccf9tf8VfA9r+mWO+folh3TJFZEHFqHrLsCVIRphtlL7qbjO2XUYRHVrlOMXcyFY0 cg= X-Received: by 2002:a05:600c:46c4:b0:483:b505:9db4 with SMTP id 5b1f17b1804b1-483c9c0f1d1mr32779065e9.31.1772185673668; Fri, 27 Feb 2026 01:47:53 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483c3b770c2sm92861155e9.10.2026.02.27.01.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 01:47:53 -0800 (PST) Message-ID: <44b01d94-427c-49d6-bac8-a5d14141b24f@linaro.org> Date: Fri, 27 Feb 2026 09:47:51 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Krzysztof Kozlowski Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Bryan O'Donoghue , Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260226-x1e-csi2-phy-v3-0-11e608759410@linaro.org> <20260226-x1e-csi2-phy-v3-1-11e608759410@linaro.org> <20260227-overjoyed-spiritual-saluki-7561c2@quoll> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260227-overjoyed-spiritual-saluki-7561c2@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/02/2026 09:41, Krzysztof Kozlowski wrote: > On Thu, Feb 26, 2026 at 12:34:25PM +0000, Bryan O'Donoghue wrote: >> Add a base schema initially compatible with x1e80100 to describe MIPI CSI2 >> PHY devices. >> >> The hardware can support both C-PHY and D-PHY modes. The CSIPHY devices >> have their own pinouts on the SoC as well as their own individual voltage >> rails. >> >> The need to model voltage rails on a per-PHY basis leads us to define >> CSIPHY devices as individual nodes. >> >> Two nice outcomes in terms of schema and DT arise from this change. >> >> 1. The ability to define on a per-PHY basis voltage rails. >> 2. The ability to require those voltage. >> >> We have had a complete bodge upstream for this where a single set of >> voltage rail for all CSIPHYs has been buried inside of CAMSS. >> >> Much like the I2C bus which is dedicated to Camera sensors - the CCI bus in >> CAMSS parlance, the CSIPHY devices should be individually modelled. >> >> Signed-off-by: Bryan O'Donoghue >> --- >> .../bindings/phy/qcom,x1e80100-csi2-phy.yaml | 114 +++++++++++++++++++++ >> 1 file changed, 114 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml >> new file mode 100644 >> index 0000000000000..c937d26ccbda9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml >> @@ -0,0 +1,114 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/phy/qcom,x1e80100-csi2-phy.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm CSI2 PHY > > Qualcomm SoC CSI2 PHY > > >> + >> +maintainers: >> + - Bryan O'Donoghue >> + >> +description: >> + Qualcomm MIPI CSI2 C-PHY/D-PHY combination PHY. Connects MIPI CSI2 sensors >> + to Qualcomm's Camera CSI Decoder. The PHY supports both C-PHY and D-PHY >> + modes. > > So just to be clear: this is not MIPI CSI, but only the CSI PHY? There > are no ports here, which seems fine for the phy and will be in the MIPI > CSI block? CAMSS ports map to the CSID - CSI Decoder yes. > >> + >> +properties: >> + compatible: >> + const: qcom,x1e80100-csi2-phy >> + >> + reg: >> + maxItems: 1 >> + >> + "#phy-cells": >> + const: 1 >> + >> + clocks: >> + maxItems: 4 >> + >> + clock-names: >> + items: >> + - const: csiphy > > probably: core or iface > >> + - const: csiphy_timer > > timer > >> + - const: camnoc_axi > > axi or noc > >> + - const: cpas_ahb > > bus, ahb or cpas, depending whether this is only one ahb or this is bus of > some cpas subblock > > See also: https://lore.kernel.org/all/20260115-sm6150_evk-v3-2-81526dd15543@oss.qualcomm.com/ > > >> + >> + interrupts: >> + maxItems: 1 >> + >> + operating-points-v2: > > Just true. It is not an array. LOL I asked a chatbot to review my submission and it told me to change this from true to a list. €90 subscription well spent... Thanks for review. --- bod