From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573AbdHQMrM (ORCPT ); Thu, 17 Aug 2017 08:47:12 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4480 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbdHQMrK (ORCPT ); Thu, 17 Aug 2017 08:47:10 -0400 Subject: Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and netpoll To: David Miller CC: , , , , , References: <20170816.114721.2286909258495579175.davem@davemloft.net> From: Aviad Krawczyk Message-ID: <44b1896a-01c0-ab0b-ede9-8582edeac9a3@huawei.com> Date: Thu, 17 Aug 2017 15:46:43 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170816.114721.2286909258495579175.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.206.50.78] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5995904A.0127,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 30893fec0f1b20a169521d8706d2e4da Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Fixed in V6. In V5 patch-set there was a problem in cover-letter msg-id. Thanks, Aviad On 8/16/2017 9:47 PM, David Miller wrote: > From: Aviad Krawczyk > Date: Wed, 16 Aug 2017 20:03:06 +0800 > >> +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb, >> + void *accel_priv, >> + select_queue_fallback_t fallback) >> +{ >> + u16 qid; >> + >> + if (skb_rx_queue_recorded(skb)) >> + qid = skb_get_rx_queue(skb); >> + else >> + qid = fallback(netdev, skb); >> + >> + return qid; >> +} > > This is a NOP, do not implement this function unless you absolutely need to > do something custom in your driver, and you do not. > > . >