From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906D5C001E0 for ; Mon, 23 Oct 2023 10:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229449AbjJWKCB (ORCPT ); Mon, 23 Oct 2023 06:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233165AbjJWJub (ORCPT ); Mon, 23 Oct 2023 05:50:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF769E4 for ; Mon, 23 Oct 2023 02:50:27 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D48FE660708F; Mon, 23 Oct 2023 10:50:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698054626; bh=GhK2Ud7iFADrChENpq0MFz1UWrwGPzQtCcCAlEyPGTM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BM5o3kiOsM4A/Yk6AEpLvWAIf3butKc5Th+izLQ8+ZCVV8ss7aCDC4aBuWoLC/udP oJuvlx9rBaMmEAZ4F5gkNtfo3ITaK41zukqJN6klysjQ5J+Ldyl68ZiWsJlnDJtawC eXKH2RQlRL2BdNYn5yi8AAFDMFPKzq7ltOxVzkHX7qSakxgXUYTQ0uhb1Zju81GDIs S2ngBqYl6LriSE4+shP54ZOgiwHBE+QX1jYXRDMOootprG5QoK7EhhDLzytBZ3Sfdo 7uJ1+3dWcOhfqM4ouEyzURyfsmexeCqlbCu800Ibi4zlVXdBLdsIiCsla7fpihhvIt wNViGEQnhvheg== Message-ID: <44b27975-1476-4da5-8427-8b0dab81b0d6@collabora.com> Date: Mon, 23 Oct 2023 11:50:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/9] soc: mailbox: Add cmdq_pkt_write_s_reg_value to support write value to reg Content-Language: en-US To: "Jason-JH.Lin" , Jassi Brar , Chun-Kuang Hu , Rob Herring , Krzysztof Kozlowski Cc: Conor Dooley , Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Jeffrey Kardatzke , Jason-ch Chen , Johnson Wang , Singo Chang , Nancy Lin , Shawn Sung References: <20231023043751.17114-1-jason-jh.lin@mediatek.com> <20231023043751.17114-5-jason-jh.lin@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231023043751.17114-5-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 23/10/23 06:37, Jason-JH.Lin ha scritto: > Add cmdq_pkt_write_s_reg_value to support write a value to a register. > > It appends write_s command to the command buffer in a CMDQ packet, > ask GCE to excute a write instruction to write a value to a register > with low 16 bits physical address offset. > > Signed-off-by: Jason-JH.Lin Please fix the commit title: soc: mediatek: cmdq: xxxx Regards, Angelo