From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C532F221FBD for ; Thu, 24 Apr 2025 11:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745493977; cv=none; b=kwAcsH/zlpbtm2H9VXHA3jeu5VfEbPIznMngvbnvtJMs90gXeXaChpHZJLv1MQPSsm7gnui+DUmqehYjx34eRolQfj5mar2kpin6IEkTi3hm4l0Tn2phSc178i4ecJLonUED0Naw6Q4LibHJwa5Mn8ll198nHNcoerr2iAEAESc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745493977; c=relaxed/simple; bh=DxWPNEYePRHJk+mrrlZ9LGFtuXks7s/MsOJehVi659w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NIel+cheiuId7tbKG8yYWm0m6mK3ClSvJnev2MVuSX+6M2sVi4hrk7h2jDiGeagDO7X2taLekqlP25wMJAJ4tOvbqVhQkKmGSRN003/860nG11OJrGmqRTZqtzhFlhDxtfltU1r2knmQk3FVZM5rI8AP3tpzjqdvwJjFWfgXggI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Y6dGXbMw; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=TBR+T+nc; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=Y6dGXbMw; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=TBR+T+nc; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Y6dGXbMw"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="TBR+T+nc"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Y6dGXbMw"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="TBR+T+nc" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DDE4921171; Thu, 24 Apr 2025 11:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745493973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oe37kHa6OjABHOtp27KFBj6FfYXoBY4b396xoyxnzoo=; b=Y6dGXbMwS9heb+/Fs+KWsMOpwCIjZapSKWgunkd7LFXKvpvmrxnf5jwRz0gf9HzIl+KaoG 72g0ZBXio+JFpCwfRXbkCAlBre+pQvocNH3qWabNaB/764VJKDy05yIVQPS0ZGIkDvvmBZ Rm+ak4vHXgE4jKoCh67xR4t18J62pqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745493973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oe37kHa6OjABHOtp27KFBj6FfYXoBY4b396xoyxnzoo=; b=TBR+T+ncVgireaKgoU8ClVbRIp/p6cLFPKGf3ZzzqNIq8casg0ygGQbFPRk+skOx7hwhNF ZhEBiBO6Y/Uf5fCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1745493973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oe37kHa6OjABHOtp27KFBj6FfYXoBY4b396xoyxnzoo=; b=Y6dGXbMwS9heb+/Fs+KWsMOpwCIjZapSKWgunkd7LFXKvpvmrxnf5jwRz0gf9HzIl+KaoG 72g0ZBXio+JFpCwfRXbkCAlBre+pQvocNH3qWabNaB/764VJKDy05yIVQPS0ZGIkDvvmBZ Rm+ak4vHXgE4jKoCh67xR4t18J62pqE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1745493973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oe37kHa6OjABHOtp27KFBj6FfYXoBY4b396xoyxnzoo=; b=TBR+T+ncVgireaKgoU8ClVbRIp/p6cLFPKGf3ZzzqNIq8casg0ygGQbFPRk+skOx7hwhNF ZhEBiBO6Y/Uf5fCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BCCE81393C; Thu, 24 Apr 2025 11:26:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dmuxK9UfCmiTOwAAD6G6ig (envelope-from ); Thu, 24 Apr 2025 11:26:13 +0000 Date: Thu, 24 Apr 2025 13:26:08 +0200 From: Daniel Wagner To: Hannes Reinecke Cc: Daniel Wagner , James Smart , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/14] nvmet-fcloop: add missing fcloop_callback_host_done Message-ID: <44b6159a-a86f-4b76-bcef-35f267e69835@flourine.local> References: <20250423-nvmet-fcloop-v5-0-3d7f968728a5@kernel.org> <20250423-nvmet-fcloop-v5-6-3d7f968728a5@kernel.org> <89289452-3647-4d94-baf9-529d145b652f@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89289452-3647-4d94-baf9-529d145b652f@suse.de> X-Spam-Level: X-Spamd-Result: default: False [-8.30 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,flourine.local:mid] X-Spam-Score: -8.30 X-Spam-Flag: NO On Thu, Apr 24, 2025 at 12:13:10PM +0200, Hannes Reinecke wrote: > > + if (!tfcp_req) { > > /* abort has already been called */ > > - return; > > + goto out_host_done; > > + } > Sure this is correct? > If the abort has been called I would have expected that all resources > are cleaned up by the abort, so we wouldn't need to do that here... Yes, it is still necessary to call fcpreq->done for this particular request. > > @@ -983,7 +984,7 @@ fcloop_fcp_abort(struct nvme_fc_local_port *localport, > > default: > > spin_unlock_irqrestore(&tfcp_req->reqlock, flags); > > WARN_ON(1); > > - return; > > + goto out_host_done; > > Do we still need the WARN_ON()? We can now gracefully recover, so a > simple log message would be sufficient here, no? The WARN_ON is there because it catches when tfcp_req is in an wrong state. It should be either in INI_IO_START, INI_IO_ACTIVE or INI_IO_COMPLETED but never INI_IO_ABORT.