From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AAC7C433F5 for ; Fri, 14 Jan 2022 14:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242024AbiANOtF (ORCPT ); Fri, 14 Jan 2022 09:49:05 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4412 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235613AbiANOtF (ORCPT ); Fri, 14 Jan 2022 09:49:05 -0500 Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jb3yS2vrCz67Cp2; Fri, 14 Jan 2022 22:46:08 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 15:49:02 +0100 Received: from [10.47.83.126] (10.47.83.126) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 14 Jan 2022 14:49:01 +0000 Subject: Re: [PATCH] perf util: Fix use after free in metric__new To: Arnaldo Carvalho de Melo , Ian Rogers CC: =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , , , , , , , , , References: <20211208171113.22089-1-jose.exposito89@gmail.com> From: John Garry Message-ID: <44b8de2c-b976-a396-2363-61a014d7e71f@huawei.com> Date: Fri, 14 Jan 2022 14:48:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.47.83.126] X-ClientProxiedBy: lhreml722-chm.china.huawei.com (10.201.108.73) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/01/2022 14:47, Arnaldo Carvalho de Melo wrote: >>> Addresses-Coverity-ID: 1494000 >>> Signed-off-by: José Expósito >> Acked-by: Ian Rogers >> >> This can only happen in the ENOMEM case, but it is a good fix. >> >> Fixes: b85a4d61d302 (perf metric: Allow modifiers on metrics) > Sorry, I missed this one_as well_, sigh... > > - Arnaldo > Isn't there a v3 out there? Not sure if you noticed... Cheers