From: Josh Hunt <johunt@akamai.com>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/1] tcp: check skb is non-NULL in tcp_rto_delta_us()
Date: Thu, 22 Aug 2024 20:33:45 -0700 [thread overview]
Message-ID: <44bae648-9ced-4b57-b7c4-95f7740dceae@akamai.com> (raw)
In-Reply-To: <CAL+tcoDh1GUL-m-UXM=WenN74wXLsgudEScJedfa=AEzt1Rs9g@mail.gmail.com>
On 8/22/24 8:27 PM, Jason Xing wrote:
>
> Hello Josh,
>
> On Fri, Aug 23, 2024 at 11:02 AM Josh Hunt <johunt@akamai.com> wrote:
>>
>> There have been multiple occassions where we have crashed in this path
>> because packets_out suggested there were packets on the write or retransmit
>> queues, but in fact there weren't leading to a NULL skb being dereferenced.
>
> Could you show us the detailed splats and more information about it so
> that we can know what exactly happened?
Hey Jason
Yeah for some reason my cover letter did not come through which has the
oops info that we hit. I'll resend it now. Fingers crossed it goes
through this time :)
Josh
next prev parent reply other threads:[~2024-08-23 3:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 2:13 [PATCH net 0/1] NULL ptr dereference in tcp_rearm_rto Josh Hunt
2024-08-23 2:13 ` [PATCH net 1/1] tcp: check skb is non-NULL in tcp_rto_delta_us() Josh Hunt
2024-08-23 3:27 ` Jason Xing
2024-08-23 3:33 ` Josh Hunt [this message]
2024-08-23 4:21 ` Josh Hunt
2024-08-23 6:42 ` Eric Dumazet
2024-08-23 7:36 ` Jason Xing
2024-08-23 3:34 [PATCH net 0/1] NULL ptr dereference in tcp_rearm_rto Josh Hunt
2024-08-23 3:34 ` [PATCH net 1/1] tcp: check skb is non-NULL in tcp_rto_delta_us() Josh Hunt
2024-08-23 6:55 ` Eric Dumazet
2024-08-23 19:43 ` Josh Hunt
2024-08-26 20:32 ` Jakub Kicinski
2024-09-06 23:16 ` Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44bae648-9ced-4b57-b7c4-95f7740dceae@akamai.com \
--to=johunt@akamai.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®