From: Imran Shaik <imran.shaik@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Taniya Das <taniya.das@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clk: qcom: gcc-glymur: Update the halt check flags for pipe clocks
Date: Fri, 26 Sep 2025 12:30:47 +0530 [thread overview]
Message-ID: <44c224d3-d5d3-4a88-bf88-34b9ab5239b3@oss.qualcomm.com> (raw)
In-Reply-To: <gprk7uhwqnj37cyl5iae64qrevkts3z266y2e5k6z72bcujhml@n5yaik3jtm2a>
On 9/26/2025 2:48 AM, Dmitry Baryshkov wrote:
> On Thu, Sep 25, 2025 at 07:10:47PM +0530, Imran Shaik wrote:
>>
>>
>> On 9/25/2025 3:49 PM, Taniya Das wrote:
>>> The pipe clocks for PCIE and USB are externally sourced and they should
>>> not be polled by the clock driver. Update the halt_check flags to 'SKIP'
>>> to disable polling for these clocks.
>>>
>>> This helps avoid the clock status stuck at 'off' warnings, which are
>>> benign, since all consumers of the PHYs must initialize a given instance
>>> before performing any operations.
>>>
>>> Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller")
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>>> ---
>>> Changes in v2:
>>> - Update the commit text to add the SoC name "glymur" [Konrad]
>>> - Update the commit subject to add more details [Konrad]
>>> - Add RB [Konrad]
>>> - Fix a typo [Markus Elfring]
>>> - Link to v1: https://lore.kernel.org/r/20250924-glymur_gcc_usb_fixes-v1-1-a90568723e64@oss.qualcomm.com
>>> ---
>>> drivers/clk/qcom/gcc-glymur.c | 24 ++++++++++++------------
>>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>> Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
>
> Note how you've responded. It will be ignored by all the tools. Please
> send it correctly.
>
My bad. Thanks for pointing it.
Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> Anyway:
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
>
>
>>
>> Thanks,
>> Imran
>
next prev parent reply other threads:[~2025-09-26 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 10:19 Taniya Das
2025-09-25 13:40 ` Imran Shaik
2025-09-25 21:18 ` Dmitry Baryshkov
2025-09-26 7:00 ` Imran Shaik [this message]
2025-10-27 14:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44c224d3-d5d3-4a88-bf88-34b9ab5239b3@oss.qualcomm.com \
--to=imran.shaik@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®